sndk: Support fabric attached SN861 #2928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-lien-sndk
force-pushed
the
fabric-fixes-sndk
branch
6 times, most recently
from
f28e6c7 to
ba41407
Compare
Since the pci device id is not available in the fabric attached case, other fields in the C2 log page are used to identify the drive. The vs-fw-activate-history and clear-fw-activate-history wdc plugin commands were ported to the sandisk plugin. Update the required libnvme commit to pick up new required function - nvme_get_uuid_list. Signed-off-by: jeff-lien-sndk <[email protected]> Reviewed-by: brandon-paupore-sndk <[email protected]>
jeff-lien-sndk
force-pushed
the
fabric-fixes-sndk
branch
from
ba41407 to
e04759e
Compare
Contributor
Author
|
@igaw Could you take a look at this PR and merge if all looks good? Thanks. |
Contributor
Author
|
@igaw Please hold off on merging this PR. I found another related issue and want to include the fix for it here. Should be coming tomorrow sometime. Thanks |
Collaborator
|
Oh sorry, fell through the cracks. Alright I'll wait for your update :) |
The drive-resize command capability was not correctly set in the nvme over fabric attached case. This change will resolve that by using the form factor value to determine which drives support this command. Signed-off-by: jeff-lien-sndk <[email protected]>
Collaborator
|
Thanks! |
Contributor
Author
|
@igaw Thanks for merging this. Do you have any plans to create v2.16 in the near future? |
Collaborator
|
Yes, there will be soon a v2.16 which will be the last of the 2.x series. FYI, we are already working on the 3.x versions in parallel nvme-cli 3 |
Contributor
Author
|
Ok, thanks for the update on the upcoming release info @igaw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the pci device id is not available in the fabric attached case, other fields in the C2 log page are used to identify the drive.
The vs-fw-activate-history and clear-fw-activate-history wdc plugin commands were ported to the sandisk plugin.
Update the required libnvme commit to pick up new required function - nvme_get_uuid_list.
Signed-off-by: jeff-lien-sndk [email protected]
Reviewed-by: brandon-paupore-sndk [email protected]