ioctl: fix dms command #2984
Merged
ioctl: fix dms command #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MaisenbacherD
left a comment
MaisenbacherD
left a comment
There was a problem hiding this comment.
I cross-checked the changes with the specs and had some comments :)
nvme.c
Outdated
| if (!dsm) | ||
| return -ENOMEM; | ||
|
|
||
| nvme_init_dsm_range(dsm, ctx_attrs, nlbs, slbas, nr); |
Contributor
There was a problem hiding this comment.
nlbs is not correctly wired up with the struct config above.
The char *blocks; member of struct config must be char *nlbs; .
Edit: Sorry, it is correctly wired up with the argconfig_parse_comma_sep_array_u32 helper.
I think we should rename the struct config members according to the spec to avoid further confusion :)
Collaborator
Author
There was a problem hiding this comment.
let's do this on top of this patch
igaw
force-pushed
the
fix-dsm
branch
2 times, most recently
from
6cff85f to
5e27c76
Compare
The DSM ranges data struct needs to be initialized. The rework dropped this part. Also the number of ranges for CDW10 is a 0's value (sic). Fixes: 6c991dc ("src: rework nvme_dsm command") Signed-off-by: Daniel Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DSM ranges data struct needs to be initialized. The rework dropped this part. Also the number of ranges for CDW10 is a 0's value (sic).
Fixes: 6c991dc ("src: rework nvme_dsm command")
Fixes: #nvme-experiments#97