Skip to content

fabrics: fix concat during connect-all #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 2 commits into from
Jan 15, 2026
+12 −2
Merged

fabrics: fix concat during connect-all #3035

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1a4162
fabrics: open transport handle for discovery controller
igaw Jan 15, 2026
c912140
fabrics: fix concat during nvme connect-all
martin-gpy Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions libnvme/src/nvme/fabrics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,8 +1193,12 @@ static int nvmf_connect_disc_entry(nvme_host_t h,
c->cfg.disable_sqflow = true;

if (e->trtype == NVMF_TRTYPE_TCP &&
e->tsas.tcp.sectype != NVMF_TCP_SECTYPE_NONE)
c->cfg.tls = true;
e->tsas.tcp.sectype != NVMF_TCP_SECTYPE_NONE) {
if (e->treq & NVMF_TREQ_REQUIRED)
c->cfg.tls = true;
else if (e->treq & NVMF_TREQ_NOT_REQUIRED)
c->cfg.concat = true;
}

ret = nvmf_add_ctrl(h, c, cfg);
if (!ret) {
Expand Down Expand Up @@ -2313,6 +2317,12 @@ static int nvmf_create_discovery_ctrl(struct nvme_global_ctx *ctx,
return -ENOMEM;
}

ret = nvme_open(ctx, c->name, &c->hdl);
if (ret) {
nvme_msg(ctx, LOG_ERR, "failed to open %s\n", c->name);
return ret;
}

/* Find out the name of discovery controller */
ret = nvme_ctrl_identify(c, id);
if (ret) {
Expand Down