Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions libnvme/src/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -55,25 +55,6 @@ libnvme = library(
install: true,
)

# Explicitly create the symlinks in the same directory. When building the
# PyPI package (pipx run build --sdist), the symbolic link don't get installed
# unless we explicitly set them as below.
# 1st: libnvme.so.X -> libnvme.so.X.Y.Z
major_version = libnvme_so_version.split('.')[0]
install_symlink(
'libnvme.so.@0@'.format(major_version),
pointing_to: 'libnvme.so.@0@'.format(libnvme_so_version),
install_dir: get_option('libdir'),
)

# 2nd: libnvme.so -> libnvme.so.X
major_version = libnvme_so_version.split('.')[0]
install_symlink(
'libnvme.so',
pointing_to: 'libnvme.so.@0@'.format(major_version),
install_dir: get_option('libdir'),
)

pkg = import('pkgconfig')
pkg.generate(libnvme,
filebase: 'libnvme',
Expand Down
6 changes: 6 additions & 0 deletions meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ else
libnvme_so_version = ver_digits + '.0'
endif

# For PyPI builds, use only the major version (e.g., '3' instead of '3.0.0').
# This avoids the need for symbolic links which pip/wheel doesn't preserve.
if get_option('pypi')
libnvme_so_version = libnvme_so_version.split('.')[0]
endif

################################################################################
prefixdir = get_option('prefix')
datadir = join_paths(prefixdir, get_option('datadir'))
Expand Down
6 changes: 6 additions & 0 deletions meson_options.txt
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,9 @@ option(
value: 'disabled',
description : 'liburing support'
)
option(
'pypi',
type : 'boolean',
value : false,
description : 'building for PyPI (use short soversion, e.g. libnvme.so.3)'
)
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ setup = [
"-Dnvme=disabled",
"-Dlibnvme=enabled",
"-Dpython=enabled",
"-Dpypi=true",
"-Dtests=false",
"-Dnvme-tests=false",
"-Dexamples=false",
Expand Down