ci: Pass in __bootc_validation as boolean, not string#148
Closed
Conversation
Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR enforces passing Sequence diagram for passing __bootc_validation as boolean in CIsequenceDiagram
participant CI as "CI Workflow"
participant tox as "tox-lsr"
participant ansible as "Ansible"
CI->>tox: Run tox-lsr with extra-vars
tox->>ansible: Pass __bootc_validation: true (YAML boolean)
ansible->>ansible: Treat __bootc_validation as boolean
Flow diagram for Terraform test retry logic including cancelled runsflowchart TD
A["Check for pending workflow"]
B["Get failed or cancelled workflow runs"]
C["If not found, exit"]
D["If found, retry workflow"]
A --> B
B -->|RUN_ID = null| C
B -->|RUN_ID != null| D
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Centralize the repeated tox-lsr version across workflows by using a shared variable or reusable workflow to simplify future upgrades.
- Consider referencing the official linux-system-roles qemu-testing guide in contributing.md instead of duplicating the full setup steps to avoid documentation drift.
- Extract the __bootc_validation extra-vars syntax into a common snippet or Action input to keep the workflows DRY and easier to update.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Centralize the repeated tox-lsr version across workflows by using a shared variable or reusable workflow to simplify future upgrades.
- Consider referencing the official linux-system-roles qemu-testing guide in contributing.md instead of duplicating the full setup steps to avoid documentation drift.
- Extract the __bootc_validation extra-vars syntax into a common snippet or Action input to keep the workflows DRY and easier to update.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass in a YAML true value as
__bootc_validation: trueusingthe --extra-vars option to ensure that
__bootc_validationistreated as a boolean and not a string value.
-e "__bootc_validation: true"You can also use JSON format:
-e '{"__bootc_validation": true}'but YAML is simpler in this case.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI configurations to correctly pass boolean extra-vars, upgrade tox-lsr across workflows, handle cancelled TF test runs, and document local CI testing setup
Enhancements:
CI:
Documentation: