Skip to content

fix: cannot use community-general version 12 - no py27 and py36 support#161

Merged
richm merged 1 commit intomainfrom
community-general-11.x
Nov 14, 2025
Merged

fix: cannot use community-general version 12 - no py27 and py36 support#161
richm merged 1 commit intomainfrom
community-general-11.x

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Nov 14, 2025

community.general version 12 has dropped support for py27 and py36 - ensure that
the roles do not install/use this version - see
ansible-collections/community.general#582

By default, installation will get the latest 11.x version. The lower bound
6.6.0 is an older version, but I don't want to restrict the ability of a user
of a particular role to use an old version, rather than forcing them to use
11.x or later. Some roles like rhc explicitly require 6.6.0 or later - I
think this is a reasonable lower bound for all roles.If a role needs a different
version, the role can define its own community_general_version in the role's
host_vars file in .github.

Standardize file format across all roles for consistency and ease of updating

This update may remove the SPDX license information from the file - this is ok -
the role/project already has a license, this file is trivial, and many
requirements files do not have the license header anyway.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Pin community.general collection to >=6.6.0,<12.0.0 to avoid unsupported version 12 and unify collection-requirements file format across roles

Bug Fixes:

  • Prevent installation of community.general v12 which drops Python 2.7 and 3.6 support by constraining version to <12.0.0

Enhancements:

  • Set a flexible lower bound of >=6.6.0 for community.general and standardize collection-requirements YAML entries across all roles

Chores:

  • Remove SPDX license headers from managed collection-requirements files

community.general version 12 has dropped support for py27 and py36 - ensure that
the roles do not install/use this version - see
ansible-collections/community.general#582

By default, installation will get the latest 11.x version. The lower bound
`6.6.0` is an older version, but I don't want to restrict the ability of a user
of a particular role to use an old version, rather than forcing them to use
`11.x` or later. Some roles like `rhc` explicitly require `6.6.0` or later - I
think this is a reasonable lower bound for all roles.If a role needs a different
version, the role can define its own `community_general_version` in the role's
`host_vars` file in .github.

Standardize file format across all roles for consistency and ease of updating

This update may remove the SPDX license information from the file - this is ok -
the role/project already has a license, this file is trivial, and many
requirements files do not have the license header anyway.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner November 14, 2025 20:10
@richm richm self-assigned this Nov 14, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Nov 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR enforces a version constraint on community.general to avoid unsupported versions and standardizes the collection-requirements file format and headers across the roles for consistency.

Entity relationship diagram for updated collection requirements

erDiagram
    COLLECTIONS {
        string name
        string version
    }
    COLLECTIONS ||--o| COMMUNITY_GENERAL : has
    COLLECTIONS ||--o| ANSIBLE_POSIX : has
    COMMUNITY_GENERAL {
        string version ">=6.6.0,<12.0.0"
    }
    ANSIBLE_POSIX {
        string version "unspecified"
    }
Loading

File-Level Changes

Change Details Files
Constrain community.general collection version
  • Add version specifier '>=6.6.0,<12.0.0' to community.general entry
  • Ensure default installs latest 11.x while allowing older versions down to 6.6.0
meta/collection-requirements.yml
Standardize collection-requirements files
  • Remove SPDX license header and replace with uniform 'DO NOT EDIT' comment
  • Convert flat list entries into mapping syntax with 'name:'
  • Reorder or normalize collection entries for consistency
tests/collection-requirements.yml
meta/collection-requirements.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Add the version constraint '>=6.6.0,<12.0.0' to tests/collection-requirements.yml so tests won’t pull in community.general v12.
  • Sort the collection entries alphabetically in both meta and test requirement files to keep their ordering consistent.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Add the version constraint '>=6.6.0,<12.0.0' to tests/collection-requirements.yml so tests won’t pull in community.general v12.
- Sort the collection entries alphabetically in both meta and test requirement files to keep their ordering consistent.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit af17dce into main Nov 14, 2025
29 checks passed
@richm richm deleted the community-general-11.x branch November 14, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant