ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox environment naming and tox-lsr version to restore compatibility with newer tox releases.

CI:

• Rename qemu and container tox environments in GitHub workflows from dot-separated to dash-separated ansible-core versions to avoid tox Python version conflicts.
• Bump tox-lsr used in all GitHub workflows from version 3.15.0 to 3.16.0.

Documentation:

• Adjust contributing documentation example to use the new dash-separated qemu tox environment name.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox-lsr dependency to 3.16.0 and renames qemu/container tox environments from dot-separated to dash-separated version identifiers to avoid tox 4.49 misinterpreting them as Python versions, with the example invocation in contributing.md updated accordingly.

File-Level Changes

Change	Details	Files
Rename qemu and container tox environments to use dash-separated ansible-core versions instead of dot-separated versions to avoid tox 4.49 conflicts.	Adjust matrix env names in qemu-kvm-integration-tests workflow from qemu-ansible-core-X.Y to qemu-ansible-core-X-Y. Adjust matrix env names in qemu-kvm-integration-tests workflow from container-ansible-core-X.Y to container-ansible-core-X-Y. Keep commented-out and duplicate scenarios consistent with the new env naming scheme.	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr version used in CI workflows from 3.15.0 to 3.16.0.	Update tox-lsr git ref in qemu-kvm-integration-tests workflow install step. Update tox-lsr git ref in ansible-lint workflow install step. Update tox-lsr git ref in ansible-managed-var-comment workflow install step. Update tox-lsr git ref in ansible-test workflow install step.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Align documentation example tox environment name with new dash-separated qemu env naming scheme.	Change example tox -e invocation in contributing guide to use qemu-ansible-core-2-20 instead of qemu-ansible-core-2.14.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In contributing.md the example now uses qemu-ansible-core-2-20, but the workflow matrix only defines environments up to 2-19; consider updating the example to match an actual tox env name that exists in this repo.
• The pip3 install of tox-lsr@3.16.0 is duplicated across multiple workflows; consider centralizing this via a reusable workflow or composite action so the version only needs to be changed in one place in future.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `contributing.md` the example now uses `qemu-ansible-core-2-20`, but the workflow matrix only defines environments up to `2-19`; consider updating the example to match an actual tox env name that exists in this repo.
- The `pip3 install` of `tox-lsr@3.16.0` is duplicated across multiple workflows; consider centralizing this via a reusable workflow or composite action so the version only needs to be changed in one place in future.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}