ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use newer testing tooling and optimize container test execution.

Enhancements:

• Switch Fedora 43 qemu and container test scenarios to use Ansible Core 2.20.
• Upgrade tox-lsr to version 3.17.0 across GitHub Actions workflows.
• Adjust container test runs to process full requirements and callback plugins on the first test, then skip them on subsequent tests for faster execution.

CI:

• Refresh GitHub Actions workflows to use tox-lsr 3.17.0 and updated Ansible versions for Fedora 43 matrix entries.

Tests:

• Optimize container test loop behavior to reduce redundant setup work after the initial test run.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 on Fedora 43 test scenarios, and adjusts container test env vars to leverage new tox-lsr behavior for faster, cleaner runs.

Flow diagram for GitHub_Action_job_installing_tox_lsr_3_17_0_and_running_tests

flowchart TD
  A["Job start"] --> B["Checkout repository"]
  B --> C["Set shell options set -euxo pipefail"]
  C --> D["Install tox-lsr 3.17.0 via pip3"]
  D --> E{"Workflow type?"}

  E -->|ansible-lint.yml| F["Convert role to collection format and run lint via tox-lsr 3.17.0"]
  E -->|ansible-managed-var-comment.yml| G["Run ansible-plugin-scan via tox-lsr 3.17.0"]
  E -->|ansible-test.yml| H["Run ansible test matrix using tox-lsr 3.17.0"]
  E -->|qemu-kvm-integration-tests.yml| I["Run qemu/container integration tests with Ansible 2.20 and new container env vars"]

  F --> J["Publish job results"]
  G --> J
  H --> J
  I --> J

  J --> K["Job end"]

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr version used in all GitHub workflows from 3.16.0 to 3.17.0.	Update pip install command in qemu-kvm integration workflow to use tox-lsr 3.17.0. Update pip install command in ansible-lint workflow to use tox-lsr 3.17.0. Update pip install command in ansible-managed-var-comment workflow to use tox-lsr 3.17.0. Update pip install command in ansible-test workflow to use tox-lsr 3.17.0.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Switch Fedora 43 qemu and container scenarios to Ansible 2.20 and adjust container test loop to use new skip flags for requirements and callback plugins.	Change Fedora 43 qemu scenario environment from qemu-ansible-core-2-19 to qemu-ansible-core-2-20. Change Fedora 43 container and bootc scenario environments from container-ansible-core-2-19 to container-ansible-core-2-20. Initialize SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to false before the first container test run, then set them to true after each iteration to speed subsequent runs. Remove old LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY debug-related environment overrides no longer needed with tox-lsr 3.17.0.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}