Skip to content

refactor: comply with Ansible partner certification checks [citest_skip]#183

Merged
richm merged 1 commit intolinux-system-roles:mainfrom
richm:refactor-comply-with-ansible-partner-cert-checks
Apr 3, 2026
Merged

refactor: comply with Ansible partner certification checks [citest_skip]#183
richm merged 1 commit intolinux-system-roles:mainfrom
richm:refactor-comply-with-ansible-partner-cert-checks

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Apr 3, 2026

https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md

Ensure that our code complies with these policies/checks and prepare for
improved ansible-lint and ansible-test checks.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Add Ansible metadata to the AD integration filter plugin and introduce version-specific sanity ignore configuration files to align with Ansible partner certification checks.

Enhancements:

  • Document the AD integration INI-to-dictionary filter plugin with Ansible-compliant metadata headers.

CI:

  • Add Ansible sanity ignore configuration files for Ansible 2.20 and 2.21 to satisfy updated partner certification and linting requirements.

https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md

Ensure that our code complies with these policies/checks and prepare for
improved ansible-lint and ansible-test checks.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner April 3, 2026 14:04
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 3, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a YAML document start marker to the AD integration filter plugin to satisfy Ansible linting/policy requirements and introduces version-specific Ansible sanity ignore configuration files to align with partner certification checks.

File-Level Changes

Change Details Files
Ensure the AD integration filter plugin YAML complies with Ansible linting/partner certification expectations.
  • Add YAML document start marker to the filter plugin metadata file to make it a valid YAML document
filter_plugins/ad_integration_from_ini.yml
Introduce Ansible sanity ignore configuration files for specific Ansible versions to prepare for stricter certification checks.
  • Add an ignore configuration file for Ansible sanity checks for version 2.20
  • Add an ignore configuration file for Ansible sanity checks for version 2.21
.sanity-ansible-ignore-2.20.txt
.sanity-ansible-ignore-2.21.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 5f57626 into linux-system-roles:main Apr 3, 2026
11 checks passed
@richm richm deleted the refactor-comply-with-ansible-partner-cert-checks branch April 3, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant