ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr version and adjust qemu/container tox environment names to avoid tox 4 Python version parsing issues.

CI:

• Bump tox-lsr used in GitHub workflows from 3.15.0 to 3.16.0.
• Rename qemu and container ansible-core tox environments in CI matrices from major.minor to major-minor notation.

Documentation:

• Refresh contributing instructions to use the new qemu tox environment name format.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox integration to work with tox 4.49 by renaming qemu/container tox environments to use dash-separated ansible-core versions and bumping tox-lsr to 3.16.0 across workflows, plus adjusting contributor docs to match.

Flow diagram for updated qemu tox usage in contributor docs

flowchart LR
  dev[Developer] --> run_tox[Run_tox_command]
  run_tox --> env_select[Select_qemu_ansible_core_env]
  env_select --> env_dash[qemu-ansible-core-2-20]
  env_dash --> tox_execute[Tox_executes_tests]
  tox_execute --> qemu_integration[QEMU_integration_tests]

Loading

File-Level Changes

Change	Details	Files
Align tox environment names with tox 4.49 parsing by switching ansible-core version suffixes from dot-separated to dash-separated and propagate these names in CI matrices.	Update qemu tox matrix env names from qemu-ansible-core-X.Y to qemu-ansible-core-X-Y in the qemu-kvm integration workflow Update container tox matrix env names from container-ansible-core-X.Y to container-ansible-core-X-Y in the qemu-kvm integration workflow Keep commented-out and duplicate matrix entries consistent with the new naming convention	.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr dependency in all GitHub Actions workflows to version 3.16.0 to pick up fixes, including the qemu env rename support.	Change pip install reference from tox-lsr@3.15.0 to tox-lsr@3.16.0 in the qemu-kvm integration workflow Change pip install reference from tox-lsr@3.15.0 to tox-lsr@3.16.0 in ansible-lint workflow Change pip install reference from tox-lsr@3.15.0 to tox-lsr@3.16.0 in ansible-managed-var-comment workflow Change pip install reference from tox-lsr@3.15.0 to tox-lsr@3.16.0 in ansible-test workflow	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Update contributor documentation to use the new dash-separated qemu tox environment naming.	Change example tox invocation from qemu-ansible-core-2.14 to qemu-ansible-core-2-20 in contributing guide to reflect new env naming convention and supported ansible-core versions	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The example in contributing.md was changed from qemu-ansible-core-2.14 to qemu-ansible-core-2-20; if this wasn’t intentional, consider either keeping the same Ansible version or aligning it with one of the versions used in the workflow matrix for consistency.
• Since the qemu/container env names changed from 2.X to 2-X, it may be worth grepping the repo for qemu-ansible-core-2. and container-ansible-core-2. to ensure there are no remaining references to the old environment names outside these workflows.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The example in `contributing.md` was changed from `qemu-ansible-core-2.14` to `qemu-ansible-core-2-20`; if this wasn’t intentional, consider either keeping the same Ansible version or aligning it with one of the versions used in the workflow matrix for consistency.
- Since the qemu/container env names changed from `2.X` to `2-X`, it may be worth grepping the repo for `qemu-ansible-core-2.` and `container-ansible-core-2.` to ensure there are no remaining references to the old environment names outside these workflows.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}