ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43#263
Closed
ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43#263
Conversation
…r fedora 43 tox-lsr 3.17.0 has some container test improvements - better output, faster runs Use Ansible 2.20 for qemu/container tests on fedora 43 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 images, while refining container test execution behavior for faster runs and clearer output in qemu-kvm integration tests. Sequence diagram for qemu-kvm integration tests with tox-lsr 3.17.0 and Ansible 2.20sequenceDiagram
actor Dev as Developer
participant GH as GitHub_Actions
participant Job as qemu-kvm_integration_job
participant Tox as Tox
participant TL as Tox_lsr_3_17_0
participant An as Ansible_2_20
participant C as Fedora_43_Container
participant Q as QEMU_KVM_VM
Dev->>GH: Push_commit_or_open_PR
GH->>Job: Start_qemu-kvm_integration_tests
Job->>Job: Checkout_repository
Job->>Job: Set_up_Python_environment
Job->>Tox: Invoke_tox
Tox->>TL: Load_tox-lsr_3_17_0_plugins
TL->>C: Start_or_prepare_test_container
TL->>An: Configure_ansible_2_20_for_tests
An->>C: Run_playbooks_in_container
TL->>Q: Start_QEMU_KVM_VM_for_integration_tests
An->>Q: Execute_integration_test_playbooks
Q-->>TL: Test_results_with_improved_output
TL-->>Job: Aggregated_results_and_logs
Job-->>GH: Job_status_and_artifacts
GH-->>Dev: CI_status_checks_updated
Flow diagram for updated ansible-test CI workflowflowchart TD
start[Trigger_ansible-test_workflow]
checkout[actions_checkout]
setup_python[Set_up_Python_environment]
install_tox_lsr[Install_tox_and_tox-lsr_3_17_0]
pull_image[Pull_Fedora_43_test_container]
configure_ansible[Configure_Ansible_2_20]
run_tox[Run_tox_envs_for_ansible-tests]
run_container_tests[Run_container_based_ansible_tests]
improved_output[Produce_improved_container_test_output]
finish[Publish_results_and_finish]
start --> checkout --> setup_python --> install_tox_lsr --> pull_image --> configure_ansible --> run_tox --> run_container_tests --> improved_output --> finish
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the container test loop, consider adding a brief comment or link explaining why it is safe to skip requirements and callback plugins after the first run, so future maintainers understand the guarantees about test isolation and environment reuse.
- Since the SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS flags are tightly coupled to tox-lsr 3.17.0 behavior, it may be worth guarding their use (or documenting in the workflow) so that future tox-lsr bumps don’t inadvertently change semantics without revisiting this logic.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the container test loop, consider adding a brief comment or link explaining why it is safe to skip requirements and callback plugins after the first run, so future maintainers understand the guarantees about test isolation and environment reuse.
- Since the SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS flags are tightly coupled to tox-lsr 3.17.0 behavior, it may be worth guarding their use (or documenting in the workflow) so that future tox-lsr bumps don’t inadvertently change semantics without revisiting this logic.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
cockpit full packages is also affected by the pcs-web-ui scriptlet systemd issue on fedora 43 bootc containers: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.0 has some container test improvements - better output, faster runs
Use Ansible 2.20 for qemu/container tests on fedora 43
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test scenarios, and optimize container test runs via environment flags.
CI: