-
Notifications
You must be signed in to change notification settings - Fork 6
ci: skip most CI checks if title contains citest skip [citest_skip] #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a conditional guard to multiple GitHub Actions CI jobs so they are skipped when a pull request title contains the marker string "[citest_skip]". Flow diagram for CI job guard based on PR title citest_skip markerflowchart TD
PR["Pull_request_opened_or_synchronized"]
CheckTitle["Check PR title contains [citest_skip]"]
RunJobs["Run guarded CI jobs"]
SkipJobs["Skip guarded CI jobs"]
PR --> CheckTitle
CheckTitle -->|contains [citest_skip]| SkipJobs
CheckTitle -->|does_not_contain [citest_skip]| RunJobs
subgraph Guarded_CI_Jobs
AL["Job ansible_lint\nif: !contains(github.event.pull_request.title, [citest_skip])"]
AMVC["Job ansible_managed_var_comment\nif: !contains(github.event.pull_request.title, [citest_skip])"]
CS["Job codespell\nif: !contains(github.event.pull_request.title, [citest_skip])"]
MDL["Job markdownlint\nif: !contains(github.event.pull_request.title, [citest_skip])"]
WOKE["Job woke\nif: !contains(github.event.pull_request.title, [citest_skip])"]
end
RunJobs --> AL
RunJobs --> AMVC
RunJobs --> CS
RunJobs --> MDL
RunJobs --> WOKE
SkipJobs -.jobs_marked_as_skipped_in_GitHub_UI.-> Guarded_CI_Jobs
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we submit a PR for a CI update or docs, we do not want to start CI checking
for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more
roles, this fires off a lot of unnecessary tests, which sometimes causes the
linux-system-roles org in github to be throttled.
When submitting a PR that can skip ci, use "[citest_skip]" in the PR title.