Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Feb 4, 2026

The new ansible-lint@v26 does not like it when there is a .collection directory
with a galaxy.yml in the converted collection, so remove it, since it is not
needed for ansible-lint.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

CI:

  • Extend ansible-lint workflow cleanup to remove the .collection directory from the converted collection directory.

…tion [citest_skip]

The new ansible-lint@v26 does not like it when there is a .collection directory
with a galaxy.yml in the converted collection, so remove it, since it is not
needed for ansible-lint.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner February 4, 2026 20:48
@richm richm self-assigned this Feb 4, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the ansible-lint GitHub Actions workflow to remove the generated .collection directory from the converted collection before running ansible-lint, aligning with ansible-lint v26 expectations.

Flow diagram for cleanup step removing .collection directory

flowchart TD
  A[Start ansible-lint job] --> B[Run tox with TOXENV=collection]
  B --> C[Set coll_dir = .tox/ansible_collections/$LSR_ROLE2COLL_NAMESPACE/$LSR_ROLE2COLL_NAME]
  C --> D[Cleanup after collection conversion]
  D --> E[Remove $coll_dir/.ansible]
  E --> F[Remove .tox/ansible-plugin-scan]
  F --> G[Remove $coll_dir/.collection]
  G --> H[Create $coll_dir/.git directory]
  H --> I[Run ansible-lint action]
Loading

File-Level Changes

Change Details Files
Extend the cleanup step in the ansible-lint CI workflow to delete the converted collection’s .collection directory.
  • Modify the cleanup rm -rf command in the ansible-lint workflow job to also remove $coll_dir/.collection after collection conversion
  • Preserve existing cleanup of $coll_dir/.ansible and .tox/ansible-plugin-scan artifacts prior to running ansible-lint
  • Maintain subsequent creation of a .git directory in the converted collection for ansible-lint action compatibility
.github/workflows/ansible-lint.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit bbabdde into main Feb 4, 2026
12 checks passed
@richm richm deleted the remove-dot-collection-dir branch February 4, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant