-
Notifications
You must be signed in to change notification settings - Fork 6
ci: tox-lsr version 3.15.0 [citest_skip] #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds back support for IPv6 in qemu VMs, which appears to be working now. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates all GitHub Actions workflows that install tox-lsr to use version 3.15.0 instead of 3.14.0, enabling the latest CI behavior (including restored IPv6 support in qemu VMs). Sequence diagram for CI job using tox-lsr 3.15.0 with IPv6-enabled qemu VMssequenceDiagram
actor Dev as Developer
participant GH as GitHub_Actions
participant Job as Workflow_job
participant Runner as Actions_runner
participant Pip as pip3
participant Tox as tox_lsr_3_15_0
participant VM as QEMU_VM
participant Net as IPv6_network
Dev->>GH: Push commit / open PR
GH->>Job: Trigger workflow
Job->>Runner: Start job on runner
Runner->>Pip: Execute install tox-lsr 3_15_0
Pip-->>Runner: tox-lsr 3_15_0 installed
Runner->>Tox: Run CI tasks
Tox->>VM: Create and configure VM
VM->>Net: Attach to IPv6 network
Net-->>VM: IPv6 connectivity available
VM-->>Tox: Test results (including IPv6)
Tox-->>Runner: CI results
Runner-->>GH: Job status
Flow diagram for GitHub Actions tox-lsr installation step updateflowchart TD
A[Workflow starts] --> B[Checkout repository]
B --> C[Set environment and dependencies]
C --> D[Run pip3 install git+https://github.com/linux-system-roles/tox-lsr@3_15_0]
D --> E{Installation successful?}
E -->|No| F[Fail job]
E -->|Yes| G[Run ansible-lint or ansible-plugin-scan via tox-lsr]
G --> H[Publish test results]
H --> I[Workflow completes]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The tox-lsr version string is duplicated across multiple workflows; consider centralizing it via a workflow-level env variable or a reusable workflow so future version bumps only require a single change.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tox-lsr version string is duplicated across multiple workflows; consider centralizing it via a workflow-level env variable or a reusable workflow so future version bumps only require a single change.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds back support for IPv6 in qemu VMs, which appears to be working now.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use the newer tox-lsr 3.15.0 release.
Build:
CI: