Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Feb 10, 2026

This adds back support for IPv6 in qemu VMs, which appears to be working now.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use the newer tox-lsr 3.15.0 release.

Build:

  • Bump tox-lsr dependency from 3.14.0 to 3.15.0 in GitHub Actions workflows to align with the latest tooling.

CI:

  • Update ansible lint, managed-var-comment, ansible-test, and qemu-kvm integration GitHub workflows to install tox-lsr 3.15.0 instead of 3.14.0.

This adds back support for IPv6 in qemu VMs, which appears to be working now.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner February 10, 2026 16:08
@richm richm self-assigned this Feb 10, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates all GitHub Actions workflows that install tox-lsr to use version 3.15.0 instead of 3.14.0, enabling the latest CI behavior (including restored IPv6 support in qemu VMs).

Sequence diagram for CI job using tox-lsr 3.15.0 with IPv6-enabled qemu VMs

sequenceDiagram
  actor Dev as Developer
  participant GH as GitHub_Actions
  participant Job as Workflow_job
  participant Runner as Actions_runner
  participant Pip as pip3
  participant Tox as tox_lsr_3_15_0
  participant VM as QEMU_VM
  participant Net as IPv6_network

  Dev->>GH: Push commit / open PR
  GH->>Job: Trigger workflow
  Job->>Runner: Start job on runner
  Runner->>Pip: Execute install tox-lsr 3_15_0
  Pip-->>Runner: tox-lsr 3_15_0 installed
  Runner->>Tox: Run CI tasks
  Tox->>VM: Create and configure VM
  VM->>Net: Attach to IPv6 network
  Net-->>VM: IPv6 connectivity available
  VM-->>Tox: Test results (including IPv6)
  Tox-->>Runner: CI results
  Runner-->>GH: Job status
Loading

Flow diagram for GitHub Actions tox-lsr installation step update

flowchart TD
  A[Workflow starts] --> B[Checkout repository]
  B --> C[Set environment and dependencies]
  C --> D[Run pip3 install git+https://github.com/linux-system-roles/tox-lsr@3_15_0]
  D --> E{Installation successful?}
  E -->|No| F[Fail job]
  E -->|Yes| G[Run ansible-lint or ansible-plugin-scan via tox-lsr]
  G --> H[Publish test results]
  H --> I[Workflow completes]
Loading

File-Level Changes

Change Details Files
Bump tox-lsr dependency from 3.14.0 to 3.15.0 in CI workflows.
  • Update ansible-lint workflow to install tox-lsr 3.15.0 via pip from the linux-system-roles GitHub repository.
  • Update ansible-managed-var-comment workflow to install tox-lsr 3.15.0 via pip from the linux-system-roles GitHub repository.
  • Update ansible-test workflow to install tox-lsr 3.15.0 via pip from the linux-system-roles GitHub repository.
  • Update qemu-kvm-integration-tests workflow to install tox-lsr 3.15.0 via pip from the linux-system-roles GitHub repository, affecting integration test behavior including IPv6 handling in qemu VMs.
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The tox-lsr version string is duplicated across multiple workflows; consider centralizing it via a workflow-level env variable or a reusable workflow so future version bumps only require a single change.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The tox-lsr version string is duplicated across multiple workflows; consider centralizing it via a workflow-level env variable or a reusable workflow so future version bumps only require a single change.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit faace89 into main Feb 10, 2026
12 checks passed
@richm richm deleted the tox-lsr-3.15.0 branch February 10, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant