Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented May 21, 2025

Update changelog and .README.html for version 1.10.0

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Prepare and document the 1.10.0 release with new feature support, bug fixes, CI updates, refactoring, test improvements, and documentation updates.

New Features:

  • Add support for using this role in container-based builds

Bug Fixes:

  • Fix the "helpers" service option
  • Fix the "interface_pci_id" role option

Enhancements:

  • Introduce a backend abstraction in firewall_lib and remove obsolete offline code

CI:

  • Assert fact structure and key entries in CI jobs
  • Bump sclorg/testing-farm-as-github-action from v3 to v4
  • Upgrade tox-lsr to v3.8.0 and rename QEMU/KVM tests
  • Add prerequisites for bootc support in CI
  • Add Fedora 42 testing and upgrade tox-lsr to v3.9.0 with lsr-report-errors for QEMU tests

Documentation:

  • Clarify in README that interface_pci_id requires running on the actual target machine and isn’t supported in container builds

Tests:

  • Apply various test fixes and additions

@sourcery-ai
Copy link

sourcery-ai bot commented May 21, 2025

Reviewer's Guide

This PR updates the project documentation for the 1.10.0 release by appending the corresponding entry to CHANGELOG.md and adding a note about container build support for the interface_pci_id option in the HTML README.

File-Level Changes

Change Details Files
Append 1.10.0 release notes to the changelog
  • Added version header with date
  • Documented new feature support in container builds
  • Listed bug fixes and other CI/refactor/test updates
CHANGELOG.md
Clarify interface_pci_id support in README
  • Inserted a paragraph stating that interface_pci_id requires a real target machine
  • Noted lack of support during container builds
.README.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.41%. Comparing base (2d7c4ba) to head (be7ba24).
Report is 82 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   61.09%   58.41%   -2.69%     
==========================================
  Files           2        2              
  Lines         910     1188     +278     
==========================================
+ Hits          556      694     +138     
- Misses        354      494     +140     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes - here's some feedback:

  • There’s a typo in the changelog entry – "abstration" should be spelled "abstraction".
  • The new feature claims container build support, but the README note says it’s not supported in containers – please reconcile or clarify this discrepancy.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Update changelog and .README.html for version 1.10.0

Signed-off-by: Rich Megginson <[email protected]>
@richm richm force-pushed the changelog-2025-05-21 branch from b9037ac to be7ba24 Compare May 21, 2025 13:51
@richm richm merged commit e3a9031 into linux-system-roles:main May 21, 2025
26 of 28 checks passed
@richm richm deleted the changelog-2025-05-21 branch May 21, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant