Skip to content

Comments

test: allow unicode literals for ansible-test#298

Merged
richm merged 1 commit intolinux-system-roles:mainfrom
richm:fix-ansible-test-issues
Oct 23, 2025
Merged

test: allow unicode literals for ansible-test#298
richm merged 1 commit intolinux-system-roles:mainfrom
richm:fix-ansible-test-issues

Conversation

@richm
Copy link
Contributor

@richm richm commented Oct 22, 2025

The code uses ipaddress which requires unicode literals.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Tests:

  • Added unicode-literal ignore entries to .sanity-ansible-ignore files for Ansible versions 2.9 through 2.16.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates ansible-test’s sanity-check ignore configurations to accommodate unicode literals required by the ipaddress module.

File-Level Changes

Change Details Files
Extend sanity-check ignore lists to allow unicode literals
  • Add unicode literal warning patterns to ignore rules
  • Suppress errors related to ipaddress usage requiring unicode literals
.sanity-ansible-ignore-2.9.txt
.sanity-ansible-ignore-2.12.txt
.sanity-ansible-ignore-2.13.txt
.sanity-ansible-ignore-2.14.txt
.sanity-ansible-ignore-2.15.txt
.sanity-ansible-ignore-2.16.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.26%. Comparing base (2d7c4ba) to head (0630081).
⚠️ Report is 104 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   61.09%   58.26%   -2.83%     
==========================================
  Files           2        2              
  Lines         910     1294     +384     
==========================================
+ Hits          556      754     +198     
- Misses        354      540     +186     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm richm force-pushed the fix-ansible-test-issues branch from 2544cb8 to e0144e6 Compare October 22, 2025 17:31
@richm
Copy link
Contributor Author

richm commented Oct 22, 2025

see linux-system-roles/.github#132

@richm richm force-pushed the fix-ansible-test-issues branch 3 times, most recently from ce62c38 to f98affa Compare October 22, 2025 19:21
The code uses ipaddress which requires unicode literals.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm force-pushed the fix-ansible-test-issues branch from f98affa to 0630081 Compare October 23, 2025 01:06
@richm richm merged commit 7f36771 into linux-system-roles:main Oct 23, 2025
29 of 31 checks passed
@richm richm deleted the fix-ansible-test-issues branch October 23, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant