ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Align CI testing and documentation with Ansible’s deprecation of injecting facts as top-level variables.

CI:

• Set ANSIBLE_INJECT_FACT_VARS=false in GitHub Actions workflows to ensure tests run with facts not injected as vars.
• Propagate an SR_ANSIBLE_INJECT_FACT_VARS flag into the tft workflow environment for downstream test execution.

Documentation:

• Update README-ostree to reference ansible_facts-based distribution variables instead of deprecated fact variables.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

CI is updated to run Ansible with fact injection disabled by default, and documentation is aligned to the newer ansible_facts access pattern to avoid deprecation warnings and future errors.

File-Level Changes

Change	Details	Files
Align README documentation with new Ansible facts access pattern.	Update description of DISTRO-VERSION to reference ansible_facts["distribution"] instead of ansible_distribution. Update description of DISTRO-VERSION to reference ansible_facts["distribution_version"] instead of ansible_distribution_version.	README-ostree.md
Configure CI workflows to run with fact injection disabled so deprecated fact-as-var usage is surfaced.	Set ANSIBLE_INJECT_FACT_VARS="false" in qemu-kvm-integration-tests workflow env block so tests run with facts not injected as top-level vars. Pass SR_ANSIBLE_INJECT_FACT_VARS=false into the TFT workflow Terraform variables/secrets string so downstream jobs also use the new default.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/tft.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider defining ANSIBLE_INJECT_FACT_VARS/SR_ANSIBLE_INJECT_FACT_VARS in a shared workflow or composite action so the default is applied consistently across CI jobs and easier to update in one place later.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider defining ANSIBLE_INJECT_FACT_VARS/SR_ANSIBLE_INJECT_FACT_VARS in a shared workflow or composite action so the default is applied consistently across CI jobs and easier to update in one place later.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}