Conversation
…tion [citest_skip] The new ansible-lint@v26 does not like it when there is a .collection directory with a galaxy.yml in the converted collection, so remove it, since it is not needed for ansible-lint. Signed-off-by: Rich Megginson <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the ansible-lint GitHub Actions workflow to delete an additional .collection directory from the converted Ansible collection before running ansible-lint v26, preventing conflicts caused by leftover collection metadata. Flow diagram for updated ansible-lint CI cleanup stepflowchart TD
A[GitHub Actions ansible-lint workflow start] --> B[Run lsr_ci_runtox with TOXENV=collection]
B --> C[Set coll_dir = .tox/ansible_collections/$LSR_ROLE2COLL_NAMESPACE/$LSR_ROLE2COLL_NAME]
C --> D[Cleanup converted collection]
subgraph Cleanup_commands
D1[rm -rf $coll_dir/.ansible]
D2[rm -rf .tox/ansible-plugin-scan]
D3[rm -rf $coll_dir/.collection]
end
D --> D1
D --> D2
D --> D3
D1 --> E[Ensure .git directory exists in coll_dir]
D2 --> E
D3 --> E
E[mkdir -p $coll_dir/.git] --> F[Run ansible-lint GitHub Action v26]
F --> G[Workflow end]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new ansible-lint@v26 does not like it when there is a .collection directory
with a galaxy.yml in the converted collection, so remove it, since it is not
needed for ansible-lint.
Signed-off-by: Rich Megginson [email protected]
Summary by Sourcery
CI: