refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Enhancements:

• Replace deprecated ansible_architecture variable references with ansible_facts['architecture'] in Red Hat 8/9/10 repo definitions.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors Ansible variable usage in RedHat vars files to use the new ansible_facts syntax for architecture, ensuring compatibility with INJECT_FACTS_AS_VARS=false and avoiding deprecation warnings in Ansible 2.20+.

File-Level Changes

Change	Details	Files
Update Ansible fact references in RedHat vars files to use ansible_facts['architecture'] instead of the deprecated ansible_architecture variable in GFS2 repository IDs.	Replace ansible_architecture with ansible_facts['architecture'] in the RedHat_8 GFS2 repository ID template string. Replace ansible_architecture with ansible_facts['architecture'] in the RedHat_9 GFS2 repository ID template string. Replace ansible_architecture with ansible_facts['architecture'] in the RedHat_10 GFS2 repository ID template string.	vars/RedHat_8.yml vars/RedHat_9.yml vars/RedHat_10.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[richm]

[citest]

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• Given the move to ansible_facts['architecture'] here, it would be good to double-check other vars/roles for remaining bare fact usages (e.g., ansible_architecture) to keep the deprecation handling consistent across the codebase.
• In vars/RedHat_10.yml the repo id still references rhel-9 (preexisting), which might be unintended for a RHEL 10-specific vars file and worth verifying while touching this area.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Given the move to `ansible_facts['architecture']` here, it would be good to double-check other vars/roles for remaining bare fact usages (e.g., `ansible_architecture`) to keep the deprecation handling consistent across the codebase.
- In `vars/RedHat_10.yml` the repo id still references `rhel-9` (preexisting), which might be unintended for a RHEL 10-specific vars file and worth verifying while touching this area.

## Individual Comments

### Comment 1
<location> `vars/RedHat_10.yml:4` </location>
<code_context>
 ---
 __gfs2_repos:
-  - id: rhel-9-for-{{ ansible_architecture }}-resilientstorage-rpms
+  - id: rhel-9-for-{{ ansible_facts['architecture'] }}-resilientstorage-rpms
     name: Resilient Storage
</code_context>

<issue_to_address>
**issue (bug_risk):** Repo id for RedHat_10 still references rhel-9, which is likely incorrect.

In the RedHat_10 vars file, this repo id still uses the `rhel-9-for-...` prefix, which is probably a copy/paste error and may point RHEL 10 hosts at the wrong channel. Please update this to the correct RHEL 10 repo id (e.g. `rhel-10-for-...`).
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): Repo id for RedHat_10 still references rhel-9, which is likely incorrect.

In the RedHat_10 vars file, this repo id still uses the rhel-9-for-... prefix, which is probably a copy/paste error and may point RHEL 10 hosts at the wrong channel. Please update this to the correct RHEL 10 repo id (e.g. rhel-10-for-...).