Skip to content

fix: ostree - add dnf/dnf5 package, add firewall packages#358

Merged
richm merged 1 commit intolinux-system-roles:mainfrom
richm:fix-ostree-install-dnf
Feb 18, 2026
Merged

fix: ostree - add dnf/dnf5 package, add firewall packages#358
richm merged 1 commit intolinux-system-roles:mainfrom
richm:fix-ostree-install-dnf

Conversation

@richm
Copy link
Contributor

@richm richm commented Feb 18, 2026

Cause: The ostree image does not install the dnf or dnf5 packages.

Consequence: The role will issue an error that the dnf command is not
found on ostree systems.

Fix: Add the dnf or dnf5 package to the ostree build manifest.

Result: The role works on ostree systems.

In addition - add the firewall packages used for testing, and ensure
that the ostree package implemenation is used.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Ensure dnf/dnf5 is available in ostree-based images so package management works on those systems.

Bug Fixes:

  • Add dnf or dnf5 to ostree runtime package manifests so roles depending on the dnf command work on ostree systems.

Enhancements:

  • Introduce ostree runtime package manifest files for CentOS, Fedora, and Red Hat variants to standardize required packages across these images.

@richm richm requested a review from tomjelinek as a code owner February 18, 2026 16:59
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 18, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds per-distro OSTree runtime package manifest files to ensure dnf/dnf5 are installed in OSTree images so the role can use the dnf command on CentOS, Fedora, and Red Hat systems.

File-Level Changes

Change Details Files
Introduce OSTree runtime package manifests for major RPM-based distros to include dnf/dnf5 in built images.
  • Add a CentOS-specific OSTree runtime package manifest and include the appropriate dnf package
  • Add a Fedora-specific OSTree runtime package manifest and include the appropriate dnf or dnf5 package depending on Fedora support
  • Add a Red Hat-specific OSTree runtime package manifest and include the appropriate dnf or dnf5 package for RHEL-based OSTree images
.ostree/packages-runtime-CentOS.txt
.ostree/packages-runtime-Fedora.txt
.ostree/packages-runtime-RedHat.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • If the three new .ostree/packages-runtime-*.txt files share most of their contents, consider extracting the common package list into a single shared include to minimize duplication and the risk of the lists diverging across CentOS/Fedora/RedHat.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- If the three new `.ostree/packages-runtime-*.txt` files share most of their contents, consider extracting the common package list into a single shared include to minimize duplication and the risk of the lists diverging across CentOS/Fedora/RedHat.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.92%. Comparing base (d1f3c0c) to head (6aad721).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files          19       19           
  Lines        1212     1212           
=======================================
  Hits         1102     1102           
  Misses        110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Cause: The ostree image does not install the dnf or dnf5 packages.

Consequence: The role will issue an error that the dnf command is not
found on ostree systems.

Fix: Add the dnf or dnf5 package to the ostree build manifest.

Result: The role works on ostree systems.

In addition - add the firewall packages used for testing, and ensure
that the ostree package implemenation is used.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm force-pushed the fix-ostree-install-dnf branch from 6ced588 to 6aad721 Compare February 18, 2026 19:44
@richm richm changed the title fix: ostree - add dnf/dnf5 package fix: ostree - add dnf/dnf5 package, add firewall packages Feb 18, 2026
@richm richm merged commit fce2eef into linux-system-roles:main Feb 18, 2026
37 of 40 checks passed
@richm richm deleted the fix-ostree-install-dnf branch February 18, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant