fix: ostree - add dnf/dnf5 package, add firewall packages#358
Merged
richm merged 1 commit intolinux-system-roles:mainfrom Feb 18, 2026
Merged
fix: ostree - add dnf/dnf5 package, add firewall packages#358richm merged 1 commit intolinux-system-roles:mainfrom
richm merged 1 commit intolinux-system-roles:mainfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds per-distro OSTree runtime package manifest files to ensure dnf/dnf5 are installed in OSTree images so the role can use the dnf command on CentOS, Fedora, and Red Hat systems. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If the three new
.ostree/packages-runtime-*.txtfiles share most of their contents, consider extracting the common package list into a single shared include to minimize duplication and the risk of the lists diverging across CentOS/Fedora/RedHat.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If the three new `.ostree/packages-runtime-*.txt` files share most of their contents, consider extracting the common package list into a single shared include to minimize duplication and the risk of the lists diverging across CentOS/Fedora/RedHat.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage 90.92% 90.92%
=======================================
Files 19 19
Lines 1212 1212
=======================================
Hits 1102 1102
Misses 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cause: The ostree image does not install the dnf or dnf5 packages. Consequence: The role will issue an error that the dnf command is not found on ostree systems. Fix: Add the dnf or dnf5 package to the ostree build manifest. Result: The role works on ostree systems. In addition - add the firewall packages used for testing, and ensure that the ostree package implemenation is used. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
6ced588 to
6aad721
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause: The ostree image does not install the dnf or dnf5 packages.
Consequence: The role will issue an error that the dnf command is not
found on ostree systems.
Fix: Add the dnf or dnf5 package to the ostree build manifest.
Result: The role works on ostree systems.
In addition - add the firewall packages used for testing, and ensure
that the ostree package implemenation is used.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Ensure dnf/dnf5 is available in ostree-based images so package management works on those systems.
Bug Fixes:
Enhancements: