ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox environments and tooling to be compatible with newer tox and tox-lsr versions.

CI:

• Rename qemu and container tox environment names in the qemu-kvm integration workflow from dotted to dashed ansible-core versions to avoid tox Python version conflicts.
• Bump tox-lsr used in all GitHub Actions workflows from 3.15.0 to 3.16.0.

Documentation:

• Adjust the qemu tox usage example in contributing documentation to use the new dashed ansible-core environment naming scheme.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox-lsr version and renames qemu/container tox environments from dot-separated to dash-separated ansible-core versions to avoid tox 4.49 misinterpreting them as Python versions, ensuring CI and local qemu testing remain functional.

File-Level Changes

Change	Details	Files
Rename qemu and container tox environments from dot-separated to dash-separated ansible-core version identifiers in the qemu KVM integration workflow matrix.	Adjust matrix.env values for qemu scenarios from qemu-ansible-core-2.X to qemu-ansible-core-2-X Adjust matrix.env values for container scenarios from container-ansible-core-2.X to container-ansible-core-2-X, including commented-out entries	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr dependency from 3.15.0 to 3.16.0 across all GitHub Actions workflows.	Update pip3 install line to use tox-lsr@3.16.0 in ansible-lint workflow Update pip3 install line to use tox-lsr@3.16.0 in ansible-managed-var-comment workflow Update pip3 install line to use tox-lsr@3.16.0 in ansible-test workflow Update pip install line to use tox-lsr@3.16.0 in python-unit-test workflow Update tox-lsr version in qemu-kvm-integration-tests workflow setup step	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Update contributor documentation to reference the new qemu tox environment name format using dash-separated ansible-core version numbers.	Change example tox invocation from qemu-ansible-core-2.14 to qemu-ansible-core-2-20 to illustrate the new naming convention	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In contributing.md, the example was changed to use qemu-ansible-core-2-20; if that tox environment is not actually defined in tox.ini, consider updating the example to match an existing env (e.g. qemu-ansible-core-2-16) so users can copy-paste it successfully.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In contributing.md, the example was changed to use `qemu-ansible-core-2-20`; if that tox environment is not actually defined in tox.ini, consider updating the example to match an existing env (e.g. `qemu-ansible-core-2-16`) so users can copy-paste it successfully.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}