Skip to content

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#364

Merged
richm merged 1 commit intomainfrom
ci-container-improvements
Mar 11, 2026
Merged

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#364
richm merged 1 commit intomainfrom
ci-container-improvements

Conversation

@richm
Copy link
Contributor

@richm richm commented Mar 11, 2026

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI testing environment to use newer tox-lsr and Ansible versions for Fedora 43 and optimize container test runs.

CI:

  • Bump tox-lsr version from 3.16.0 to 3.17.0 across GitHub Actions workflows.
  • Adjust Fedora 43 qemu and container test matrices to run against Ansible Core 2.20 instead of 2.19.
  • Optimize container test execution by configuring requirements and callback plugins to run fully on the first test only and be skipped on subsequent tests.

…r fedora 43 [citest_skip]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from tomjelinek as a code owner March 11, 2026 00:17
@richm richm self-assigned this Mar 11, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43, and optimizes container test runs by controlling requirements and callback plugin setup between test iterations.

File-Level Changes

Change Details Files
Bump tox-lsr version from 3.16.0 to 3.17.0 across CI workflows to leverage improved container test behavior.
  • Update tox-lsr pip install reference to 3.17.0 in qemu integration tests workflow.
  • Update tox-lsr pip install reference to 3.17.0 in ansible-lint workflow.
  • Update tox-lsr pip install reference to 3.17.0 in ansible-managed-var-comment workflow.
  • Update tox-lsr pip install reference to 3.17.0 in ansible-test workflow.
  • Update tox-lsr pip install reference to 3.17.0 in python-unit-test workflow.
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/python-unit-test.yml
Use Ansible Core 2.20 for Fedora 43 qemu and container test scenarios.
  • Change Fedora 43 qemu test matrix entry to use qemu-ansible-core-2-20 environment.
  • Change Fedora 43 container test matrix entry to use container-ansible-core-2-20 environment.
  • Change Fedora 43 bootc container test matrix entry to use container-ansible-core-2-20 environment.
.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop to run full setup once, then skip requirements and callback plugin setup on subsequent test files for faster, cleaner runs.
  • Remove previous LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY debug-related overrides before running container tests.
  • Introduce SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS environment variables, set to false before first container test run.
  • Within the test loop, set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each iteration to skip repeated setup work on subsequent runs.
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider defining the tox-lsr version in a single reusable place (e.g., a workflow env variable, composite action, or reusable workflow) so you don't have to update the hard-coded 3.17.0 string across multiple workflow files in future bumps.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider defining the tox-lsr version in a single reusable place (e.g., a workflow env variable, composite action, or reusable workflow) so you don't have to update the hard-coded `3.17.0` string across multiple workflow files in future bumps.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 7a554a7 into main Mar 11, 2026
14 checks passed
@richm richm deleted the ci-container-improvements branch March 11, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant