ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#365
Merged
ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#365
Conversation
…s them [citest_skip] tox-lsr 3.17.1 has a fix for the broken container tests There was one shell function for both setting up the callback plugins and the connection plugin. When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not set, so all subsequent tests failed. The connection plugin must be present and the env. var. must be set in order to run any container tests. The code was fixed to ensure that there is always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS is always set and contains this path. Also, setting up the callback plugins and the connection plugin is already idempotent, so no reason to skip them. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates GitHub Actions workflows to use tox-lsr 3.17.1 and ensures container tests always configure callback/connection plugins instead of conditionally skipping them, fixing broken container-based CI runs. Sequence diagram for container_tests_setup_with_tox_lsr_3_17_1sequenceDiagram
actor Dev as Developer
participant GH as GitHub_Actions
participant R as Runner
participant P as Python_Environment
participant T as tox_lsr_3_17_1
participant CP as Callback_Plugins
participant CONN as Connection_Plugin
participant ENV as Environment_Variables
participant CTEST as Container_Tests
Dev->>GH: Push commit / open PR
GH->>R: Start CI workflow
R->>P: Initialize Python environment
R->>P: pip install git_https_github_com_linux_system_roles_tox_lsr_3_17_1
P->>T: Invoke tox for container tests
T->>CP: Ensure callback plugins installed (idempotent)
T->>CONN: Ensure connection plugin installed in required path (idempotent)
T->>ENV: Set ANSIBLE_CONNECTION_PLUGINS to include connection plugin path
T->>CTEST: Run container based tests using configured plugins
CTEST-->>T: Test results
T-->>R: tox exit code and logs
R-->>GH: Report CI status on PR
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The tox-lsr version string is duplicated across multiple workflows; consider defining it once via a shared workflow, environment variable, or workflow-level
envvalue to avoid drift on future bumps. - In the workflows you mix
pipandpip3for installing tox-lsr; consider standardizing on one (likelypython -m pip) to avoid subtle environment differences across jobs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tox-lsr version string is duplicated across multiple workflows; consider defining it once via a shared workflow, environment variable, or workflow-level `env` value to avoid drift on future bumps.
- In the workflows you mix `pip` and `pip3` for installing tox-lsr; consider standardizing on one (likely `python -m pip`) to avoid subtle environment differences across jobs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.1 has a fix for the broken container tests
There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.
Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use the latest tox-lsr release and ensure container-related tests run with the required Ansible plugins configured.
CI: