Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Aug 5, 2025

If the ansible connection is local, make the tests_default_wrapper.yml
test use local connection also.

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Tests:

  • Add conditional in inventory.yaml.j2 to set ansible_connection to local and ansible_host to localhost for local connections

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 5, 2025

Reviewer's Guide

This PR enhances the tests inventory Jinja template to detect when Ansible is using a local connection and apply that connection and host directly, wrapping the existing host variable loop in an else block.

File-Level Changes

Change Details Files
Add logic to select local connection in the inventory template
  • Add {% if ansible_connection == "local" %} branch
  • Set ansible_connection: local and ansible_host: localhost
  • Wrap the existing hostvars loop in an else block under the new condition
tests/inventory.yaml.j2

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
Copy link
Contributor Author

richm commented Aug 5, 2025

[citest]

If the ansible connection is local, make the tests_default_wrapper.yml
test use local connection also.

Signed-off-by: Rich Megginson <[email protected]>
@richm richm force-pushed the test-default-wrapper branch from 899d89e to 41c6aa7 Compare August 5, 2025 16:28
@richm
Copy link
Contributor Author

richm commented Aug 5, 2025

[citest]

@richm richm merged commit 8a74cff into linux-system-roles:main Aug 5, 2025
23 of 25 checks passed
@richm richm deleted the test-default-wrapper branch August 5, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant