Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Aug 13, 2025

This will also help with cleanup - removing files used by kdump
before the handlers are run causes test errors.

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Tests:

  • Add meta: flush_handlers steps in tests_default_reboot.yml, tests_ssh.yml, and tests_ssh_reboot.yml to run handlers after role invocation for cleanup stability.

This will also help with cleanup - removing files used by kdump
before the handlers are run causes test errors.

Signed-off-by: Rich Megginson <[email protected]>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 13, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR ensures kdump role handlers are executed immediately after each role invocation in test playbooks by inserting ‘meta: flush_handlers’ tasks, which also enables proper cleanup and prevents test errors.

File-Level Changes

Change Details Files
Trigger handler execution after each kdump role inclusion
  • Insert a ‘meta: flush_handlers’ task named ‘Notify and run handlers’ following the include_role call in tests_default_reboot.yml
  • Insert a ‘meta: flush_handlers’ task named ‘Notify and run handlers’ following the include_role call in tests_ssh.yml
  • Insert a ‘meta: flush_handlers’ task named ‘Notify and run handlers again’ following the include_role call in tests_ssh_reboot.yml
tests/tests_default_reboot.yml
tests/tests_ssh.yml
tests/tests_ssh_reboot.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
Copy link
Contributor Author

richm commented Aug 13, 2025

[citest]

@richm
Copy link
Contributor Author

richm commented Aug 13, 2025

ansible-lint issue is ansible/ansible-lint#4702

@richm
Copy link
Contributor Author

richm commented Aug 13, 2025

looks like some problem with kdumpctl rebuild on fedora-42 when using qemu and qcow2 image:

# kdumpctl rebuild
kdump: Rebuilding /boot/initramfs-6.14.0-63.fc42.x86_64kdump.img
kdump: mkdumprd: failed to make kdump initrd

@richm richm merged commit 9bbcd0b into linux-system-roles:main Aug 13, 2025
24 of 26 checks passed
@richm richm deleted the test-call-handler branch August 13, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants