Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Aug 13, 2025

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Fix SSH reboot test failures by enabling fact gathering and adding debug tasks to capture host facts, server variables, and kdump configuration.

Bug Fixes:

  • Enable fact gathering in the SSH reboot test playbook to ensure necessary variables are available.

Tests:

  • Add debug tasks in tests/tests_ssh_reboot.yml to log host facts, kdump server variables, and /etc/kdump.conf content for troubleshooting.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 13, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR enhances the SSH reboot test by enabling Ansible fact gathering and inserting debug tasks to surface host facts, kdump-related variables, and the kdump configuration for troubleshooting failures.

File-Level Changes

Change Details Files
Enable fact gathering at play start
  • Add gather_facts: true under the play definition
tests/tests_ssh_reboot.yml
Insert debug tasks to aid SSH reboot diagnostics
  • Debug0 loops through hostvars to print ansible_facts
  • Debug1 prints kdump SSH and inventory variables
  • Debug2 cats /etc/kdump.conf with changed_when: false
tests/tests_ssh_reboot.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
Copy link
Contributor Author

richm commented Aug 13, 2025

[citest]

Signed-off-by: Rich Megginson <[email protected]>
@richm richm force-pushed the test-fix-ssh_reboot branch from 88e46ac to 28fd7da Compare August 14, 2025 13:18
@richm
Copy link
Contributor Author

richm commented Aug 14, 2025

[citest]

@richm
Copy link
Contributor Author

richm commented Aug 14, 2025

[citest]

@richm richm closed this Aug 18, 2025
@richm richm deleted the test-fix-ssh_reboot branch August 18, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant