ci: Pass in __bootc_validation as boolean, not string#248
Closed
Conversation
Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Contributor
Reviewer's GuideThis PR adjusts CI configurations so that the __bootc_validation extra var is passed as a YAML boolean, updates workflow actions to v5, upgrades the tox-lsr dependency, enhances the TF CI rerun logic, and adds a new “Running CI Tests Locally” section to contributing.md. Flow diagram for passing __bootc_validation as YAML boolean in CIflowchart TD
A["CI Workflow"] --> B["Pass extra-vars to Ansible"]
B --> C["__bootc_validation: true (YAML boolean)"]
C --> D["Ansible interprets as boolean"]
Flow diagram for enhanced TF CI rerun logicflowchart TD
A["TF CI rerun script"] --> B["Query workflow runs with gh api"]
B --> C["Filter runs by display_title == PR_TITLE"]
C --> D["Select runs with conclusion == failure or cancelled"]
D --> E["Get RUN_ID for rerun"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider splitting the large docs and workflow version bumps into separate commits or PRs so that the actual
__bootc_validationboolean change stays isolated and easier to review. - Since you updated tox-lsr from 3.11.0 to 3.11.1 across multiple workflows, consider centralizing that version in a shared matrix or variable to prevent future drift.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider splitting the large docs and workflow version bumps into separate commits or PRs so that the actual `__bootc_validation` boolean change stays isolated and easier to review.
- Since you updated tox-lsr from 3.11.0 to 3.11.1 across multiple workflows, consider centralizing that version in a shared matrix or variable to prevent future drift.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass in a YAML true value as
__bootc_validation: trueusingthe --extra-vars option to ensure that
__bootc_validationistreated as a boolean and not a string value.
-e "__bootc_validation: true"You can also use JSON format:
-e '{"__bootc_validation": true}'but YAML is simpler in this case.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Improve CI configurations and documentation across workflows
New Features:
Bug Fixes:
Enhancements:
Documentation: