ci: rollout several recent changes to CI testing#249
Merged
Conversation
* Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
* Use tox-lsr version 3.11.1
* Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
* Update contributing.md documentation
* Update number of nodes to use in testing farm, if needed
* remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Contributor
Reviewer's GuideThis PR standardizes and enhances CI pipelines by upgrading core dependencies and GitHub Actions versions, refining test invocation flags, improving cancellation handling, and adding local CI testing documentation. Flow diagram for improved test cancellation handling in tft_citest_bad.ymlflowchart TD
A["Check if workflow is still running"] --> B["If running, exit"]
B --> C["If not running, check for failed or cancelled runs"]
C --> D["If found, get RUN_ID"]
D --> E["If not found, exit"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The repeated pip3 install of tox-lsr@3.11.1 across multiple workflows would be easier to maintain if you extracted the version into a single reusable variable or a composite step.
- You’ve added a sizable CI-testing guide to contributing.md—consider splitting this into its own PR or a separate docs file to keep the CI rollout focused and easier to review.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The repeated pip3 install of tox-lsr@3.11.1 across multiple workflows would be easier to maintain if you extracted the version into a single reusable variable or a composite step.
- You’ve added a sizable CI-testing guide to contributing.md—consider splitting this into its own PR or a separate docs file to keep the CI rollout focused and easier to review.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__bootc_validation: trueusingthe --extra-vars option to ensure that
__bootc_validationistreated as a boolean and not a string value.
-e "__bootc_validation: true"You can also use JSON format:
-e '{"__bootc_validation": true}'but YAML is simpler in this case.
Use tox-lsr version 3.11.1
Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
Update contributing.md documentation
Update number of nodes to use in testing farm, if needed
remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use the latest GitHub Action and tox-lsr versions, enforce boolean handling for validation flags, and improve CI test reliability.
Bug Fixes:
Enhancements:
Documentation: