ci: Add Fedora 42; use tox-lsr 3.9.0; use lsr-report-errors for qemu tests#239
Merged
ci: Add Fedora 42; use tox-lsr 3.9.0; use lsr-report-errors for qemu tests#239
Conversation
…tests Add Fedora 42 to testing farm test matrix, drop Fedora 40 Use tox-lsr 3.9.0 for the `--lsr-report-errors-url` argument. Add the argument `--lsr-report-errors-url DEFAULT` to the qemu test so that the errors will be written to the output log. This uses the output callback https://github.com/linux-system-roles/auto-maintenance/blob/main/callback_plugins/lsr_report_errors.py Use the check_logs.py script https://github.com/linux-system-roles/auto-maintenance/blob/main/check_logs.py with the `--github-action-format` argument to format the errors in a github action friendly manner. Rename the log files `-FAIL.log` or `-SUCCESS.log` depending on status. This is compatible with the way the testing farm log files are named, and makes it easy to tell if a test passed or failed from the log file name. Upload README.html as artifacts of the build_docs job for debugging Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR enhances CI workflows by adding Fedora 42 support, upgrading tox-lsr to 3.9.0, improving QEMU test error reporting via lsr-report-errors and check_logs.py, standardizing log file names with status suffixes, and uploading README.html as a build_docs artifact. Sequence Diagram: Enhanced QEMU Test Error ReportingsequenceDiagram
participant Runner as GitHub Actions Runner
participant TestScript as QEMU Test Script
participant LSRCallback as lsr_report_errors.py
participant CheckLogsScript as check_logs.py
participant FileSystem as Log Storage
Runner->>TestScript: Execute QEMU tests (with --lsr-report-errors-url DEFAULT)
alt Test Execution
TestScript->>LSRCallback: (test error occurs)
LSRCallback->>FileSystem: Write error details to output log
end
Runner->>CheckLogsScript: Execute check_logs.py --github-action-format
CheckLogsScript->>FileSystem: Read output log
CheckLogsScript->>CheckLogsScript: Format errors for GitHub Actions
CheckLogsScript->>FileSystem: Rename log file (e.g., to test-FAIL.log or test-SUCCESS.log)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @richm - I've reviewed your changes - here's some feedback:
- Pin the check_logs.py download to a specific commit or tag instead of
refs/heads/mainto avoid breaking changes in your CI when upstream evolves. - Consider centralizing the tox-lsr version string in a shared variable or reusable workflow to simplify future bumps across all GitHub Actions files.
- Double-check that any other scripts or artifact uploads still referencing
<test>.logare updated to use the new-SUCCESS.log/-FAIL.logfilenames so nothing is missed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Fedora 42 to testing farm test matrix, drop Fedora 40
Use tox-lsr 3.9.0 for the
--lsr-report-errors-urlargument.Add the argument
--lsr-report-errors-url DEFAULTto the qemu test so thatthe errors will be written to the output log. This uses the output callback
https://github.com/linux-system-roles/auto-maintenance/blob/main/callback_plugins/lsr_report_errors.py
Use the check_logs.py script
https://github.com/linux-system-roles/auto-maintenance/blob/main/check_logs.py
with the
--github-action-formatargument to format the errorsin a github action friendly manner.
Rename the log files
-FAIL.logor-SUCCESS.logdepending on status.This is compatible with the way the testing farm log files are named, and
makes it easy to tell if a test passed or failed from the log file name.
Upload README.html as artifacts of the build_docs job for debugging
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Enhance the CI pipelines by upgrading tox-lsr, updating the Fedora matrix, improving QEMU test error reporting and log naming, integrating formatted failure logs, and preserving documentation artifacts.
Enhancements: