refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Enhancements:

• Replace direct use of ansible_distribution and related variables with ansible_facts lookups across test playbooks and shared vars to conform to newer Ansible fact access patterns.

[sourcery-ai]

Reviewer's Guide

Refactors all Ansible distribution/architecture conditionals in tests and shared vars to use the structured ansible_facts dictionary instead of legacy top-level fact variables, making the role/tests compatible with INJECT_FACTS_AS_VARS=false and future Ansible versions.

File-Level Changes

Change	Details	Files
Replace deprecated top-level Ansible fact variables with ansible_facts[...] in all test playbook conditionals and related helper vars.	Update distribution-based when clauses in firewall, SELinux, default datasources, keyserver, pmie, pmlogger, and various verify-* test playbooks to reference ansible_facts['distribution'], ansible_facts['distribution_major_version'], ansible_facts['distribution_version'], and ansible_facts['architecture'] as appropriate. Adjust test vars and main vars helper flags that detect Red Hat/Fedora distributions to use ansible_facts['distribution'] instead of ansible_distribution.	tests/check_firewall_selinux.yml tests/check_default_datasources.yml tests/check_keyserver.yml tests/check_pmie.yml tests/check_pmlogger.yml tests/tests_bz1855539.yml tests/tests_bz1855544.yml tests/tests_verify_auth.yml tests/tests_verify_bpftrace.yml tests/tests_verify_from_elasticsearch.yml tests/tests_verify_from_spark.yml tests/tests_verify_fullstack.yml tests/tests_verify_graph.yml tests/tests_verify_mssql.yml tests/tests_verify_postfix.yml tests/tests_verify_query.yml tests/check_pmie_webhook.yml tests/tests_verify_into_elasticsearch.yml tests/tests_verify_into_spark.yml tests/tests_verify_notification.yml tests/tests_verify_pmie_webhook.yml tests/vars/rh_distros_vars.yml vars/main.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[richm]

[citest]