Skip to content

Conversation

@spetrosi
Copy link
Collaborator

@spetrosi spetrosi commented Feb 6, 2026

Update changelog and .README.html for version 2.6.6

Signed-off-by: Sergei Petrosian spetrosi@redhat.com

Summary by Sourcery

Document the 2.6.6 release, including the AD integration behavior change and related CI and refactoring updates.

Bug Fixes:

  • Clarify that AD integration always sets krb5_canonicalize=false to avoid Kerberos principal canonicalization issues when joining to AD.

Enhancements:

  • Improve AD integration documentation structure and add guidance for skipping ad_integration when nodes are already joined to AD.

CI:

  • Document CI workflow updates in the changelog, including dependency bumps, Fedora test matrix changes, defaulting to ANSIBLE_INJECT_FACT_VARS=false, and conditional CI skipping based on PR titles.

Documentation:

  • Update .README.html AD considerations section to better describe required variables, the option to skip ad_integration, and the krb5_canonicalize=false behavior.
  • Add changelog entry for version 2.6.6 with details on the bug fix, CI updates, and refactors.

Chores:

  • Record internal refactors in the changelog, including changes to fact handling and setup module subset usage.

Update changelog and .README.html for version 2.6.6

Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
@spetrosi spetrosi requested a review from richm as a code owner February 6, 2026 10:17
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 6, 2026

Reviewer's Guide

Updates documentation for AD integration behavior and records the 2.6.6 release changes in the changelog, including a bug fix for krb5 canonicalization and several CI/refactor updates.

File-Level Changes

Change Details Files
Clarify and restructure AD integration configuration documentation in the generated HTML README, and document new behavior around krb5 canonicalization and conditional AD joining.
  • Restructured the AD integration variable description into a nested list to better associate required variables with the ad_integration role.
  • Converted paragraph-based descriptions of ad_integration variables into list items for consistency and readability.
  • Clarified that managed nodes already joined to AD can skip the ad_integration role via mssql_ad_join=false.
  • Documented that the role now sets krb5_canonicalize=false when joining the AD realm to avoid principal canonicalization issues.
.README.html
Add 2.6.6 release entry capturing bug fix and CI/refactor changes.
  • Recorded version 2.6.6 release date and created a new section at the top of the changelog.
  • Documented the bug fix ensuring krb5_canonicalize is always set to false when connecting to AD.
  • Summarized several CI-related updates, including GitHub Actions version bumps, Fedora test matrix changes, ansible-lint updates, and conditional CI behavior based on PR titles.
CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@spetrosi
Copy link
Collaborator Author

spetrosi commented Feb 6, 2026

[citest]

@spetrosi spetrosi merged commit c31508a into linux-system-roles:main Feb 6, 2026
17 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant