fix: Prioritize find link info by permanent MAC address, with fallback to current address#749
Merged
liangwen12year merged 1 commit intolinux-system-roles:mainfrom Jan 7, 2025
Conversation
…k to current address Updated the link_info_find method to prioritize matching links by perm-address when it is valid and available. If the perm-address is unavailable (None or "00:00:00:00:00:00"), the method falls back to matching by address. Additionally, if ifname is provided, it takes precedence and returns the corresponding linkinfo immediately. The change resolves scenarios where multiple network interfaces might share the same current MAC address (address), leading to potential ambiguity in link matching. By prioritizing the permanent MAC address (perm-address), the method provides a more precise and consistent match. This is particularly crucial in environments with: - MAC address spoofing or dynamic changes, where the current MAC address may not reliably identify the interface. - Virtual interfaces or VLANs, which often lack a valid perm-address and rely on the parent interface's address. - Ambiguity when multiple interfaces share the same address. This change improves the robustness of MAC address matching by ensuring that permanent addresses are prioritized while maintaining a reliable fallback mechanism for interfaces with no permanent address. Signed-off-by: Wen Liang <liangwen12year@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
===========================================
+ Coverage 20.40% 43.11% +22.71%
===========================================
Files 10 12 +2
Lines 1485 3124 +1639
Branches 436 0 -436
===========================================
+ Hits 303 1347 +1044
- Misses 1181 1777 +596
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
[citest] |
Contributor
|
[citest_bad] |
richm
approved these changes
Jan 6, 2025
c341683
into
linux-system-roles:main
23 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement:
Updated the link_info_find method to prioritize matching links by perm-address when it is valid and available. If the perm-address is unavailable (None or "00:00:00:00:00:00"), the method falls back to matching by address. Additionally, if ifname is provided, it takes precedence and returns the corresponding linkinfo immediately.
Reason:
The change resolves scenarios where multiple network interfaces might
share the same current MAC address (address), leading to potential
ambiguity in link matching. By prioritizing the permanent MAC address
(perm-address), the method provides a more precise and consistent match.
This is particularly crucial in environments with:
Result:
This change improves the robustness of MAC address matching by ensuring
that permanent addresses are prioritized while maintaining a reliable
fallback mechanism for interfaces with no permanent address.
Issue Tracker Tickets (Jira or BZ if any):