test: exclude qemu interfaces from dhcp #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
==========================================
+ Coverage 43.11% 43.25% +0.13%
==========================================
Files 12 12
Lines 3124 3121 -3
==========================================
+ Hits 1347 1350 +3
+ Misses 1777 1771 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
[citest] |
richm
force-pushed
the
test-exclude-qemu-interfaces-from-dhcp
branch
from
535acec to
dcd7295
Compare
When running tests with a qemu managed node, the dhcp used by qemu interferes with the dhcp used in the test, which can cause the test to hang. Exclude the qemu interfaces from using the test dhcp. Note that this only affects the qemu tests - testing farm and other tests with "real" machines will have a different mac address - the mac addresses used below are specific to qemu virtual devices. Also, just in case tests still timeout, add a tests/ansible.cfg with a 240 second task timeout to ensure any hung tasks are killed. This will cause the playbook to exit with an error. Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
test-exclude-qemu-interfaces-from-dhcp
branch
from
dcd7295 to
705282f
Compare
Signed-off-by: Rich Megginson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests with a qemu managed node, the dhcp
used by qemu interferes with the dhcp used in the test, which
can cause the test to hang. Exclude the qemu interfaces from
using the test dhcp. Note that this only affects the qemu tests -
testing farm and other tests with "real" machines will have a
different mac address - the mac addresses used below are specific
to qemu virtual devices.
Also include a tests/ansible.cfg with a task_timeout=240 to kill
any tasks which take longer than 240 seconds, in case there are
still hangs. This will cause the test to exit with an error.
Signed-off-by: Rich Megginson [email protected]