-
Notifications
You must be signed in to change notification settings - Fork 112
ci: Run integration test on ubuntu-latest #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThe GitHub Actions workflow for integration tests was updated to use File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
3184a36 to
bcb848b
Compare
ubuntu-20.04 is EOL, and workflows don't start any more. The test runs in a podman container anyway, so there is no need to hardcode the host version. Signed-off-by: Martin Pitt <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
==========================================
+ Coverage 43.11% 43.25% +0.13%
==========================================
Files 12 12
Lines 3124 3121 -3
==========================================
+ Hits 1347 1350 +3
+ Misses 1777 1771 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ssh connection failure, so this needs some work. This is too much of a distraction for me today, but at least that PR is a reminder (for me and others). @liangwen12year if you have time, please have a look. Thanks! |
|
The integration tests are still going to fail because of tests_mac_address_match.yml because there is no secondary ethernet interface. We either need to 1) provide another interface for these tests or 2) skip this test or 3) eliminate the integration tests. |
|
@richm yes, but the failure here is much more fundamental than that -- it can't connect with ssh. Completely untested hunch: logging in as "root" is disabled in SSH by default now? |
That's really odd - why is it trying to use |
|
Good question -- my initial gut feeling was that it would run I really don't want to distract myself with this today, sorry. |
I think we should just remove these tests. If the network team wants to fix them and reinstall them, that is fine. |
|
@martinpitt , can you please resolve the conflicts first and mark it as |
|
@liangwen12year I am not working on this. This was a half-hearted attempt to unbreak these tests, but I don't have time to dive into them. For now it's mostly a reminder for anyone who is interested in them. |
|
No time any more to work on this, this was just a hopeful drive-by attempt. For anyone who cares about these tests, please fix them. |
ubuntu-20.04 is EOL, and workflows don't start any more. The test runs in a podman container anyway, so there is no need to hardcode the host version.
Signed-off-by: Martin Pitt [email protected]
See https://github.com/linux-system-roles/network/actions/runs/14889262363/job/41817004604?pr=786
Summary by Sourcery
CI: