Skip to content

Conversation

@martinpitt
Copy link
Contributor

@martinpitt martinpitt commented May 8, 2025

ubuntu-20.04 is EOL, and workflows don't start any more. The test runs in a podman container anyway, so there is no need to hardcode the host version.

Signed-off-by: Martin Pitt [email protected]


See https://github.com/linux-system-roles/network/actions/runs/14889262363/job/41817004604?pr=786

Summary by Sourcery

CI:

  • Updated integration test workflow to use the latest Ubuntu runner

@sourcery-ai
Copy link

sourcery-ai bot commented May 8, 2025

Reviewer's Guide

The GitHub Actions workflow for integration tests was updated to use ubuntu-latest as the runner, replacing the previous ubuntu-20.04 which has reached its end-of-life.

File-Level Changes

Change Details Files
Updated the operating system for the integration test runner.
  • Changed runs-on from ubuntu-20.04 to ubuntu-latest in the integration job.
.github/workflows/integration.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@martinpitt martinpitt force-pushed the u2004 branch 2 times, most recently from 3184a36 to bcb848b Compare May 8, 2025 05:45
ubuntu-20.04 is EOL, and workflows don't start any more. The test runs
in a podman container anyway, so there is no need to hardcode the host
version.

Signed-off-by: Martin Pitt <[email protected]>
@martinpitt martinpitt changed the title CI: Run integration test on ubuntu-latest di: Run integration test on ubuntu-latest May 8, 2025
@martinpitt martinpitt changed the title di: Run integration test on ubuntu-latest ci: Run integration test on ubuntu-latest May 8, 2025
@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.25%. Comparing base (1b57520) to head (e2d420f).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
+ Coverage   43.11%   43.25%   +0.13%     
==========================================
  Files          12       12              
  Lines        3124     3121       -3     
==========================================
+ Hits         1347     1350       +3     
+ Misses       1777     1771       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martinpitt
Copy link
Contributor Author

ssh connection failure, so this needs some work. This is too much of a distraction for me today, but at least that PR is a reminder (for me and others). @liangwen12year if you have time, please have a look. Thanks!

@richm
Copy link
Contributor

richm commented May 8, 2025

The integration tests are still going to fail because of tests_mac_address_match.yml because there is no secondary ethernet interface. We either need to 1) provide another interface for these tests or 2) skip this test or 3) eliminate the integration tests.

@martinpitt
Copy link
Contributor Author

@richm yes, but the failure here is much more fundamental than that -- it can't connect with ssh. Completely untested hunch: logging in as "root" is disabled in SSH by default now?

@richm
Copy link
Contributor

richm commented May 8, 2025

@richm yes, but the failure here is much more fundamental than that -- it can't connect with ssh. Completely untested hunch: logging in as "root" is disabled in SSH by default now?

That's really odd - why is it trying to use ssh in a container test?

@martinpitt
Copy link
Contributor Author

Good question -- my initial gut feeling was that it would run ansible-playbook on the host which controls (via ssh) the CentOS container. But that's not the case, ansible runs with -i localhost from inside.

I really don't want to distract myself with this today, sorry.

@richm
Copy link
Contributor

richm commented May 8, 2025

Good question -- my initial gut feeling was that it would run ansible-playbook on the host which controls (via ssh) the CentOS container. But that's not the case, ansible runs with -i localhost from inside.

I really don't want to distract myself with this today, sorry.

I think we should just remove these tests. If the network team wants to fix them and reinstall them, that is fine.

@liangwen12year
Copy link
Contributor

liangwen12year commented Jun 15, 2025

@martinpitt , can you please resolve the conflicts first and mark it as Ready for Review instead of using the draft mode?

@martinpitt
Copy link
Contributor Author

@liangwen12year I am not working on this. This was a half-hearted attempt to unbreak these tests, but I don't have time to dive into them. For now it's mostly a reminder for anyone who is interested in them.

@martinpitt
Copy link
Contributor Author

No time any more to work on this, this was just a hopeful drive-by attempt. For anyone who cares about these tests, please fix them.

@martinpitt martinpitt closed this Jul 1, 2025
@martinpitt martinpitt deleted the u2004 branch July 1, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants