Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented May 19, 2025

The container based integration tests are broken and
unmaintained. We don't need them anymore anyway.

If you want to run tests in a container, use tox-lsr.
https://github.com/linux-system-roles/tox-lsr?tab=readme-ov-file#container-testing

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Remove all container-based integration tests and related infrastructure, including documentation, Dockerfiles, scripts, and CI workflow, and direct users to use tox-lsr for container testing

CI:

  • Remove GitHub Actions workflow for integration tests

Documentation:

  • Remove integration test instructions from contributing guide

Tests:

  • Delete container-based integration test scripts and Dockerfiles

The container based integration tests are broken and
unmaintained.  We don't need them anymore anyway.

If you want to run tests in a container, use tox-lsr.
https://github.com/linux-system-roles/tox-lsr?tab=readme-ov-file#container-testing

Signed-off-by: Rich Megginson <[email protected]>
@richm richm requested a review from liangwen12year as a code owner May 19, 2025 20:44
@sourcery-ai
Copy link

sourcery-ai bot commented May 19, 2025

Reviewer's Guide

Remove legacy container-based integration tests and related infrastructure, cleaning up documentation and CI settings and directing users to use tox-lsr for container testing.

File-Level Changes

Change Details Files
Removed Podman-based integration test documentation from contributing guide
  • Deleted step-by-step Podman container setup
  • Removed instructions for running and cleaning up tests
  • Stripped notes on unsupported tests
contributing.md
Deleted obsolete integration test infrastructure files
  • Removed Dockerfiles for C7, C8S, and C9S network-role containers
  • Deleted run_test.sh script
  • Removed GitHub Actions integration workflow
.github/Dockerfile.c7-network-role
.github/Dockerfile.c8s-network-role
.github/Dockerfile.c9s-network-role
.github/run_test.sh
.github/workflows/integration.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.25%. Comparing base (1b57520) to head (aa6416f).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
+ Coverage   43.11%   43.25%   +0.13%     
==========================================
  Files          12       12              
  Lines        3124     3121       -3     
==========================================
+ Hits         1347     1350       +3     
+ Misses       1777     1771       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm richm merged commit d1083aa into linux-system-roles:main May 19, 2025
29 of 31 checks passed
@richm richm deleted the remove-integration-tests branch May 19, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant