-
Notifications
You must be signed in to change notification settings - Fork 112
ci: get rid of integration tests - broken, unmaintained #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The container based integration tests are broken and unmaintained. We don't need them anymore anyway. If you want to run tests in a container, use tox-lsr. https://github.com/linux-system-roles/tox-lsr?tab=readme-ov-file#container-testing Signed-off-by: Rich Megginson <[email protected]>
Reviewer's GuideRemove legacy container-based integration tests and related infrastructure, cleaning up documentation and CI settings and directing users to use tox-lsr for container testing. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @richm - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
+ Coverage 43.11% 43.25% +0.13%
==========================================
Files 12 12
Lines 3124 3121 -3
==========================================
+ Hits 1347 1350 +3
+ Misses 1777 1771 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The container based integration tests are broken and
unmaintained. We don't need them anymore anyway.
If you want to run tests in a container, use tox-lsr.
https://github.com/linux-system-roles/tox-lsr?tab=readme-ov-file#container-testing
Signed-off-by: Rich Megginson [email protected]
Summary by Sourcery
Remove all container-based integration tests and related infrastructure, including documentation, Dockerfiles, scripts, and CI workflow, and direct users to use tox-lsr for container testing
CI:
Documentation:
Tests: