Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Dec 5, 2025

add qemu tests for Fedora 43, drop Fedora 41

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI QEMU and container integration test matrix to target newer Fedora images.

CI:

  • Add Fedora 43 QEMU and container test jobs using ansible-core 2.19 images.
  • Remove Fedora 41 QEMU and container test jobs, including bootc variants, from the workflow.

add qemu tests for Fedora 43, drop Fedora 41

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner December 5, 2025 20:39
@richm richm self-assigned this Dec 5, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the GitHub Actions QEMU/KVM integration workflow to test Fedora 43 (both QEMU and container/bootc variants) while removing references to Fedora 41 and aligning Fedora 43 jobs with ansible-core 2.19 environments.

File-Level Changes

Change Details Files
Expand QEMU and container integration test matrix to Fedora 43 while dropping Fedora 41 entries and updating ansible-core versions for the new images.
  • Add a QEMU integration test job entry for the fedora-43 image using the qemu-ansible-core-2.19 environment.
  • Remove the commented-out Fedora 41 QEMU job that was disabled due to an ansible/libdnf5 bug.
  • Remove Fedora 41 container and Fedora 41 bootc test entries from the matrix.
  • Add Fedora 43 container and Fedora 43 bootc test entries using the container-ansible-core-2.19 environment, while keeping Fedora 42 entries unchanged.
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • For the Fedora entries, double-check that the ansible-core versions are intentionally different between QEMU and container runs (e.g., Fedora 42 using 2.19 for QEMU but 2.17 for containers) to avoid surprising behavior when comparing results across environments.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- For the Fedora entries, double-check that the ansible-core versions are intentionally different between QEMU and container runs (e.g., Fedora 42 using 2.19 for QEMU but 2.17 for containers) to avoid surprising behavior when comparing results across environments.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit cebd5c5 into main Dec 5, 2025
23 checks passed
@richm richm deleted the ci-qemu-fedora-43 branch December 5, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants