refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update Ansible role variables and tests to use ansible_facts-based access instead of deprecated top-level fact variables.

Enhancements:

• Replace direct use of deprecated Ansible fact variables with ansible_facts lookups in role defaults and test fixtures to be compatible with INJECT_FACTS_AS_VARS=false.

Tests:

• Adjust test comments and test variable definitions to reference ansible_facts keys rather than deprecated fact variables.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors Ansible variable usage to rely on ansible_facts lookups instead of deprecated implicit fact variables, updating both role defaults and associated test fixtures/comments.

Flow diagram for using ansible_facts when INJECT_FACTS_AS_VARS is false

flowchart TD
  Start["Playbook runs role"] --> GatherFacts["Ansible gathers facts"]
  GatherFacts --> CheckSetting{"INJECT_FACTS_AS_VARS is true?"}

  CheckSetting -->|"Yes"| DeprecatedPath["Deprecated: tasks may use ansible_distribution"]
  CheckSetting -->|"No"| FactsMap["Facts available only via ansible_facts map"]

  FactsMap --> GetDistribution["Use ansible_facts['distribution']"]
  GetDistribution --> CheckRHDistro{"ansible_facts['distribution'] in __pam_pwd_rh_distros?"}
  GetDistribution --> CheckRHDistroFedora{"ansible_facts['distribution'] in __pam_pwd_rh_distros_fedora?"}

  CheckRHDistro --> SetVarRHDistro["Set __pam_pwd_is_rh_distro"]
  CheckRHDistroFedora --> SetVarRHDistroFedora["Set __pam_pwd_is_rh_distro_fedora"]

  SetVarRHDistro --> RoleTasks["Role tasks use new boolean vars"]
  SetVarRHDistroFedora --> RoleTasks

Loading

File-Level Changes

Change	Details	Files
Use ansible_facts keys instead of deprecated top-level fact variables in role logic for distro detection.	Replace ansible_distribution checks in Red Hat/Fedora detection variables with ansible_facts['distribution'] membership checks in defaults. Mirror the same ansible_facts-based Red Hat/Fedora detection logic in the test vars fixture to keep tests aligned with role behavior.	defaults/main.yml tests/vars/rh_distros_vars.yml
Update test documentation comments to describe fact access via ansible_facts instead of deprecated implicit fact variables.	Adjust commented examples of distribution/os_family templating to reference ansible_facts['distribution'], ansible_facts['distribution_version'], ansible_facts['distribution_major_version'], and ansible_facts['os_family']. Keep the surrounding varfiles templating logic unchanged, relying only on the updated comment guidance for fact access.	tests/tests_include_vars_from_parent.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[richm]

[citest]

[sourcery-ai]

Hey - I've left some high level feedback:

• In tests/tests_include_vars_from_parent.yml, the updated comments reference ansible_facts[...] while the varfiles expression still uses facts[...]; consider aligning these to avoid confusion about which variable set is actually used.
• Where you now access ansible_facts['distribution'], consider using a safer pattern like ansible_facts.get('distribution', '') (or a default filter) if this role may run with fact gathering disabled to avoid undefined-variable issues.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `tests/tests_include_vars_from_parent.yml`, the updated comments reference `ansible_facts[...]` while the `varfiles` expression still uses `facts[...]`; consider aligning these to avoid confusion about which variable set is actually used.
- Where you now access `ansible_facts['distribution']`, consider using a safer pattern like `ansible_facts.get('distribution', '')` (or a `default` filter) if this role may run with fact gathering disabled to avoid undefined-variable issues.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}