ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr version and align qemu/container tox environment names with ansible-core versions to avoid tox 4 testenv parsing issues.

CI:

• Bump tox-lsr used in GitHub Actions workflows from 3.15.0 to 3.16.0.
• Rename qemu and container ansible-core tox environment names in integration test workflow from dotted to dashed version numbers (e.g. 2.16 → 2-16).

Documentation:

• Update contributing guide example to use the new dashed qemu ansible-core tox environment name.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox/tox-lsr configuration so qemu/container ansible-core environments use dash-separated version identifiers instead of dot-separated ones, and aligns GitHub workflows and documentation with tox-lsr 3.16.0 and the new env names.

Sequence diagram for tox invocation with dash-separated qemu env

sequenceDiagram
  participant Dev as Developer
  participant Shell as Shell
  participant Tox as tox_4_49
  participant ToxLSR as tox-lsr_3_16_0
  participant Env as qemu-ansible-core-2-20_env

  Dev->>Shell: tox -e qemu-ansible-core-2-20
  Shell->>Tox: start tox with env qemu-ansible-core-2-20
  Tox->>ToxLSR: resolve environment configuration
  ToxLSR-->>Tox: return settings for qemu-ansible-core-2-20_env
  Tox->>Env: create and run environment
  Env-->>Tox: execute tests via QEMU
  Tox-->>Shell: report test results
  Shell-->>Dev: display test summary

Loading

File-Level Changes

Change	Details	Files
Align GitHub Actions qemu/container matrix env names with dash-separated tox environments used by tox-lsr 3.16.0.	Rename qemu ansible-core tox environments from major.minor to major-minor (e.g., qemu-ansible-core-2.16 → qemu-ansible-core-2-16) in the qemu-kvm integration workflow matrix. Rename container ansible-core tox environments from major.minor to major-minor in the same matrix, including commented-out scenarios.	.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr used in CI workflows to version 3.16.0 to pick up fixes for qemu tox env naming.	Bump tox-lsr Git reference from 3.15.0 to 3.16.0 in the qemu-kvm integration workflow. Bump tox-lsr Git reference from 3.15.0 to 3.16.0 in ansible-lint, ansible-managed-var-comment, and ansible-test workflows.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Update contributor documentation to reflect new dash-separated qemu tox environment naming and current example version.	Change example tox invocation from qemu-ansible-core-2.14 to qemu-ansible-core-2-20 in contributing instructions for running qemu tests locally.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The example in contributing.md changes the ansible-core version from 2.14 to 2.20 while also renaming the env format; if the intent was only to change the naming scheme, consider keeping the same version or briefly clarifying the version bump rationale.
• After renaming the tox envs from X.Y to X-Y in the GitHub workflows, double-check that all corresponding env names in tox configuration (e.g. tox.ini) and any scripts referencing them have been updated to avoid mismatches at runtime.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The example in contributing.md changes the ansible-core version from 2.14 to 2.20 while also renaming the env format; if the intent was only to change the naming scheme, consider keeping the same version or briefly clarifying the version bump rationale.
- After renaming the tox envs from `X.Y` to `X-Y` in the GitHub workflows, double-check that all corresponding env names in tox configuration (e.g. tox.ini) and any scripts referencing them have been updated to avoid mismatches at runtime.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}