Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Jun 9, 2025

NOTE: This also requires upgrading to tox-lsr 3.11.0

Ansible 2.19 will be released soon and has some changes which will
require fixes in system roles. This adds 2.19 to our testing matrix
on fedora 42 so that we can start addressing these issues.

python 3.13 is now being used on some platforms.

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Update CI workflows to test with Ansible 2.19 on Fedora 42 and upgrade tox-lsr to 3.11.0

New Features:

  • Add Ansible 2.19 to Fedora 42 testing matrix

Enhancements:

  • Bump tox-lsr dependency to 3.11.0 across multiple CI workflows

NOTE: This also requires upgrading to tox-lsr 3.11.0

Ansible 2.19 will be released soon and has some changes which will
require fixes in system roles.  This adds 2.19 to our testing matrix
on fedora 42 so that we can start addressing these issues.

python 3.13 is now being used on some platforms.

Signed-off-by: Rich Megginson <[email protected]>
@richm richm requested a review from spetrosi as a code owner June 9, 2025 16:27
@richm richm self-assigned this Jun 9, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 9, 2025

Reviewer's Guide

This PR updates the CI workflows to test Ansible Core 2.19 on Fedora 42 and bumps the tox-lsr dependency to version 3.11.0 across all relevant workflows to align with Python 3.13 support.

File-Level Changes

Change Details Files
Add Ansible 2.19 testing for Fedora 42
  • Switched the qemu-kvm integration test env for Fedora 42 from ansible-core-2.17 to 2.19
  • Updated the tft workflow’s Fedora-42 Ansible version to 2.19
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/tft.yml
Upgrade tox-lsr to v3.11.0
  • Replaced pip install of [email protected] with @3.11.0 in integration tests
  • Applied the same bump in ansible-lint, ansible-managed-var-comment, and ansible-test workflows
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 7c9747d into main Jun 10, 2025
25 of 26 checks passed
@richm richm deleted the changes-20250609-1 branch June 10, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants