Conversation
On some versions of ansible/jinja, the YAML format does not work, so use the JSON format to pass in __bootc_validation Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate CI workflow to pass the __bootc_validation flag in JSON format for compatibility with Ansible/Jinja versions that fail on YAML syntax. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Wrap the JSON string in single quotes or escape nested quotes to avoid unintended shell expansion when passing extra vars.
- Update other CI jobs and scripts to use the JSON format for __bootc_validation for consistency across workflows.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Wrap the JSON string in single quotes or escape nested quotes to avoid unintended shell expansion when passing extra vars.
- Update other CI jobs and scripts to use the JSON format for __bootc_validation for consistency across workflows.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some versions of ansible/jinja, the YAML format does not work, so use
the JSON format to pass in __bootc_validation
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
CI: