Conversation
…tion [citest_skip] The new ansible-lint@v26 does not like it when there is a .collection directory with a galaxy.yml in the converted collection, so remove it, since it is not needed for ansible-lint. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the ansible-lint GitHub Actions workflow to additionally remove the converted collection’s .collection directory during cleanup, avoiding conflicts with ansible-lint v26 while keeping the rest of the linting flow unchanged. Flow diagram for updated ansible-lint workflow cleanup stepflowchart TD
A[Start ansible-lint job] --> B[Run lsr_ci_setup_env]
B --> C[Run lsr_ci_runtox with TOXENV=collection]
C --> D[Set coll_dir to .tox/ansible_collections/$LSR_ROLE2COLL_NAMESPACE/$LSR_ROLE2COLL_NAME]
D --> E[Cleanup converted collection]
subgraph Cleanup
E --> F[Remove coll_dir/.ansible]
F --> G[Remove .tox/ansible-plugin-scan]
G --> H[Remove coll_dir/.collection]
end
H --> I[Create coll_dir/.git directory]
I --> J[Run ansible-lint GitHub Action]
J --> K[End ansible-lint job]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new ansible-lint@v26 does not like it when there is a .collection directory
with a galaxy.yml in the converted collection, so remove it, since it is not
needed for ansible-lint.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
CI: