fix: use the right systemd service for remediations in EL 10+#209
Merged
richm merged 1 commit intolinux-system-roles:mainfrom Jan 24, 2025
Merged
fix: use the right systemd service for remediations in EL 10+#209richm merged 1 commit intolinux-system-roles:mainfrom
richm merged 1 commit intolinux-system-roles:mainfrom
Conversation
richm
reviewed
Jan 20, 2025
EL 10 has a newer yggdrasil service for remediations, so instead of
'rhcd' the upstream name 'yggdrasil' is used.
Hence:
- create an helper variable for the service name depending on the EL
version; since Insights is specific to RHEL, it is possible to assume
the name based on the major version of the distribution
- use the new variable when enabling or disabling the service for
remediations
- in the test case for remediation:
- export the variables of the role as public, so the new private
variable can be used
- set an helper fact with the systemd service including the '.service'
extension
Fixes: CCT-1057
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
ptoscano
force-pushed
the
insights-rhc-service
branch
from
6e4ead4 to
d3fc6de
Compare
Contributor
|
[citest] |
|
This LGTM. Thanks @ptoscano! |
richm
approved these changes
Jan 24, 2025
Contributor
richm
left a comment
richm
left a comment
There was a problem hiding this comment.
el10 podman issues are known and unrelated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EL 10 has a newer yggdrasil service for remediations, so instead of 'rhcd' the upstream name 'yggdrasil' is used.
Hence:
Fixes: CCT-1057