tests: stop adding pools to the activation key#210
Merged
ptoscano merged 1 commit intolinux-system-roles:mainfrom Jan 20, 2025
Merged
tests: stop adding pools to the activation key#210ptoscano merged 1 commit intolinux-system-roles:mainfrom
ptoscano merged 1 commit intolinux-system-roles:mainfrom
Conversation
The Candlepin account used for tests uses SCA, and thus any activation key for it can already access to the whole content of the organization of the account. The addition of the pools to the activation key is thus redundant, and upcoming versions of Candlepin will not allow this behaviour anymore. Hence, stop adding pools to the activation key, which is no more needed. There is no behaviour change. Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Collaborator
Author
|
[citest] |
richm
approved these changes
Jan 20, 2025
Collaborator
Author
|
[citest bad] |
Collaborator
Author
|
The c10s failures are due to The other combinations are OK; should I merge this? |
Contributor
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Candlepin account used for tests uses SCA, and thus any activation key for it can already access to the whole content of the organization of the account. The addition of the pools to the activation key is thus redundant, and upcoming versions of Candlepin will not allow this behaviour anymore.
Hence, stop adding pools to the activation key, which is no more needed.
There is no behaviour change.