ci: rollout several recent changes to CI testing #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
* Use tox-lsr version 3.11.1
* Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
* Update contributing.md documentation
* Update number of nodes to use in testing farm, if needed
* remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson <[email protected]>
Reviewer's GuideThe PR standardizes and upgrades CI pipelines by switching to actions/checkout@v5, bumping tox-lsr to 3.11.1, ensuring boolean treatment for Flow diagram for citest bad comment workflow handling cancelled runsflowchart TD
A["Trigger citest bad comment workflow"] --> B["Check if workflow is still running"]
B -->|If running| C["Exit with message"]
B -->|If not running| D["Query workflow runs for PR title"]
D --> E["Select runs with conclusion 'failure' or 'cancelled'"]
E --> F["Get RUN_ID"]
F -->|If RUN_ID is null| G["Exit: Failed workflow not found"]
F -->|If RUN_ID found| H["Proceed with workflow actions"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider refactoring the repeated Actions workflows into a reusable workflow or composite action to DRY up the repeated checkout and tox-lsr installation steps.
- The new section in contributing.md duplicates detailed standard-test-roles instructions—linking to the upstream guide instead could reduce maintenance overhead and avoid stale content.
- Add a brief comment in the tft_citest_bad workflow explaining why ‘cancelled’ workflows are treated alongside failures to help future maintainers understand the change.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider refactoring the repeated Actions workflows into a reusable workflow or composite action to DRY up the repeated checkout and tox-lsr installation steps.
- The new section in contributing.md duplicates detailed standard-test-roles instructions—linking to the upstream guide instead could reduce maintenance overhead and avoid stale content.
- Add a brief comment in the tft_citest_bad workflow explaining why ‘cancelled’ workflows are treated alongside failures to help future maintainers understand the change.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__bootc_validation: trueusingthe --extra-vars option to ensure that
__bootc_validationistreated as a boolean and not a string value.
-e "__bootc_validation: true"You can also use JSON format:
-e '{"__bootc_validation": true}'but YAML is simpler in this case.
Use tox-lsr version 3.11.1
Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
Update contributing.md documentation
Update number of nodes to use in testing farm, if needed
remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson [email protected]
Summary by Sourcery
Roll out multiple CI workflow updates including upgrading actions/checkout to v5, bumping tox-lsr to 3.11.1, refining test scripts to handle boolean vars and cancelled runs, and enhancing local CI documentation.
CI:
Documentation: