ci: skip most CI checks if title contains citest skip [citest_skip]#257
Merged
ci: skip most CI checks if title contains citest skip [citest_skip]#257
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a conditional guard to multiple GitHub Actions workflows so that most CI jobs are skipped when a pull request title contains the marker string "[citest_skip]". Sequence diagram for CI job skipping when PR title contains citest_skip markersequenceDiagram
actor Developer
participant GitHub
participant Workflow_ansible_lint as ansible-lint.yml_job
participant Workflow_codespell as codespell.yml_job
Developer->>GitHub: Create or update pull request (with or without [citest_skip] in title)
GitHub-->>Workflow_ansible_lint: Trigger workflow with pull_request event
GitHub-->>Workflow_codespell: Trigger workflow with pull_request event
alt Title contains [citest_skip]
Workflow_ansible_lint->>Workflow_ansible_lint: Evaluate if !contains(title, [citest_skip])
Workflow_ansible_lint-->>GitHub: Condition false, job skipped
Workflow_codespell->>Workflow_codespell: Evaluate if !contains(title, [citest_skip])
Workflow_codespell-->>GitHub: Condition false, job skipped
else Title does not contain [citest_skip]
Workflow_ansible_lint->>Workflow_ansible_lint: Evaluate if !contains(title, [citest_skip])
Workflow_ansible_lint-->>GitHub: Condition true, run job steps
Workflow_codespell->>Workflow_codespell: Evaluate if !contains(title, [citest_skip])
Workflow_codespell-->>GitHub: Condition true, run job steps
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- For workflows that are also triggered by non-PR events (e.g.,
push),github.event.pull_requestwill be undefined and the currentifwill fail; consider guarding ongithub.event_namefirst, e.g.if: github.event_name != 'pull_request' || !contains(github.event.pull_request.title, '[citest_skip]'). - If you intend this to be a general convention across repositories, you might want to centralize the skip logic (e.g., via a reusable workflow or a shared expression pattern) to avoid repeating the literal
[citest_skip]condition in every job and to keep behavior consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For workflows that are also triggered by non-PR events (e.g., `push`), `github.event.pull_request` will be undefined and the current `if` will fail; consider guarding on `github.event_name` first, e.g. `if: github.event_name != 'pull_request' || !contains(github.event.pull_request.title, '[citest_skip]')`.
- If you intend this to be a general convention across repositories, you might want to centralize the skip logic (e.g., via a reusable workflow or a shared expression pattern) to avoid repeating the literal `[citest_skip]` condition in every job and to keep behavior consistent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we submit a PR for a CI update or docs, we do not want to start CI checking
for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more
roles, this fires off a lot of unnecessary tests, which sometimes causes the
linux-system-roles org in github to be throttled.
When submitting a PR that can skip ci, use "[citest_skip]" in the PR title.