Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented May 20, 2025

Update changelog and .README.html for version 1.5.1

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Update changelog for version 1.5.1 with the new snapshot manager feature and CI enhancements, and refine README HTML styling and content

New Features:

  • Add support for snapshot manager backing the role

Enhancements:

  • Enhance CI workflows with ansible-lint bump, codespell, test plan refinements, qemu test improvements, and tox-lsr upgrades

Documentation:

  • Improve code block CSS in README HTML for better text-size adjustment and span display
  • Fix "filesystem" typo in README HTML

Update changelog and .README.html for version 1.5.0

Signed-off-by: Rich Megginson <[email protected]>
@richm richm requested a review from spetrosi as a code owner May 20, 2025 00:23
@sourcery-ai
Copy link

sourcery-ai bot commented May 20, 2025

Reviewer's Guide

This PR updates the changelog to include the new release notes and refines the HTML README’s code block styling, along with a small documentation typo fix.

File-Level Changes

Change Details Files
Add new release entry to CHANGELOG
  • Insert version header and date
  • Add 'New Features' section
  • Add 'Other Changes' CI updates list
CHANGELOG.md
Refine README HTML styling and correct typo
  • Add -webkit-text-size-adjust CSS rule
  • Adjust display and line-height for code spans
  • Update indentation rule in print media
  • Fix 'filesytem' typo to 'filesystem'
.README.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@richm richm closed this May 20, 2025
@richm richm deleted the changelog-2025-05-19 branch May 20, 2025 00:24
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- ci: ansible-plugin-scan is disabled for now (#87)
- ci: bump ansible-lint to v25; provide collection requirements for ansible-lint (#90)
- ci: Check spelling with codespell (#91)
- ci: Add test plan that runs CI tests and customize it for each role (#92)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (typo): Grammatical error: 'customize' should be 'customizes'.

Use “customizes” to match “runs” in “...that runs CI tests and customizes it...”.

Suggested change
- ci: Add test plan that runs CI tests and customize it for each role (#92)
- ci: Add test plan that runs CI tests and customizes it for each role (#92)

- ci: bump ansible-lint to v25; provide collection requirements for ansible-lint (#90)
- ci: Check spelling with codespell (#91)
- ci: Add test plan that runs CI tests and customize it for each role (#92)
- ci: In test plans, prefix all relate variables with SR_ (#93)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (typo): Typo: 'relate' should be 'related'.

Replace it with 'related'.

Suggested change
- ci: In test plans, prefix all relate variables with SR_ (#93)
- ci: In test plans, prefix all related variables with SR_ (#93)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant