-
Notifications
You must be signed in to change notification settings - Fork 5
docs(changelog): version 1.6.0 [citest skip] #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update changelog and .README.html for version 1.6.0 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR prepares the 1.6.0 release by extending the documentation to cover new ‘bootable’ and experimental ‘use_copr’ options (including TOC and YAML examples) and updates CHANGELOG.md with the new feature and numerous CI enhancements. Class diagram for updated snapshot_lvm_set structure with bootable optionclassDiagram
class snapshot_lvm_set {
+name: string
+bootable: bool
+volumes: Volume[]
}
class Volume {
+name: string
+vg: string
+lv: string
+percent_space_required: int
+mountpoint: string
+mount_origin: bool
}
snapshot_lvm_set "1" -- "*" Volume: contains
Class diagram for new snapshot_lvm_bootable and snapshot_use_copr optionsclassDiagram
class snapshot_lvm_bootable {
+value: bool (default: false)
}
class snapshot_use_copr {
+value: bool (default: unset)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Ensure that the anchors and headings for snapshot_lvm_bootable and snapshot_use_copr in .README.html exactly match the variable names in defaults/main.yml so users won’t hit mismatches.
- Consider collapsing the numerous CI bump entries in CHANGELOG.md into a single “ci: bump dependencies and actions” bullet to keep the changelog more concise.
- It may help to include a minimal playbook snippet showing how to set snapshot_use_copr: true so users can quickly see how to enable the experimental feature.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure that the anchors and headings for snapshot_lvm_bootable and snapshot_use_copr in .README.html exactly match the variable names in defaults/main.yml so users won’t hit mismatches.
- Consider collapsing the numerous CI bump entries in CHANGELOG.md into a single “ci: bump dependencies and actions” bullet to keep the changelog more concise.
- It may help to include a minimal playbook snippet showing how to set snapshot_use_copr: true so users can quickly see how to enable the experimental feature.
## Individual Comments
### Comment 1
<location> `.README.html:397-401` </location>
<code_context>
excluded. For example, <code>snapshot_lvm_vg_include: "^sql_db_"</code>
will only operate on volume groups whose names start with
<code>sql_db_</code>. This uses the Python <code>re.search</code>.</p>
+<h2 id="snapshot_lvm_bootable">snapshot_lvm_bootable</h2>
+<p>Boolean - default is false. Only supported on operating systems that
+support snapshot manager (snapm). When set to true, and passed to the
</code_context>
<issue_to_address>
**suggestion:** Explicitly mention the default value and OS support in the variable documentation.
Consider adding a brief note on how the flag behaves on unsupported systems (e.g., ignored or triggers an error) to clarify expected outcomes for users.
```suggestion
<h2 id="snapshot_lvm_bootable">snapshot_lvm_bootable</h2>
<p>
<strong>Boolean</strong> — <strong>default: false</strong>.<br>
This flag is <strong>only supported</strong> on operating systems that provide snapshot manager (<code>snapm</code>).<br>
When set to <code>true</code> and passed to the <code>snapshot</code> command, the snapshot created will have a corresponding boot entry. The boot entry will be removed when the snapset is removed.<br>
<strong>On unsupported systems</strong>, this flag is ignored and has no effect; no boot entry will be created.
</p>
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Update changelog and .README.html for version 1.6.0
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update documentation and changelog for v1.6.0 by adding bootable snapshot support and an experimental COPR option, and record recent CI workflow enhancements
New Features:
Documentation: