ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Configure CI Ansible-based tests to run with fact injection disabled by default.

CI:

• Set ANSIBLE_INJECT_FACT_VARS=false for qemu-kvm integration tests workflow.
• Propagate SR_ANSIBLE_INJECT_FACT_VARS=false into the TFT CI workflow environment for Terraform-based tests.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates CI and test-related configuration to run Ansible-based tests with ANSIBLE_INJECT_FACT_VARS disabled, aligning the project’s automated testing with the upcoming Ansible 2.20+ behavior that no longer injects facts as top-level variables.

Flow diagram for CI job setting SR_ANSIBLE_INJECT_FACT_VARS

flowchart TD
  A[Commit or PR opened] --> B[GitHub Actions starts tft.yml job]
  B --> C[Set job environment variables<br>SR_ARTIFACTS_DIR<br>SR_TEST_LOCAL_CHANGES<br>SR_LSR_USER<br>SR_ARTIFACTS_URL<br>SR_ANSIBLE_INJECT_FACT_VARS=false]
  C --> D[Run Terraform based test harness]
  D --> E[Terraform invokes Ansible tests]
  E --> F[Ansible runs with facts not injected as top level vars]
  F --> G[Warnings or errors caught in CI if deprecated fact vars are used]

Loading

File-Level Changes

Change	Details	Files
Configure GitHub Actions integration tests to run with ANSIBLE_INJECT_FACT_VARS disabled so Ansible facts are not injected as variables during CI.	Set ANSIBLE_INJECT_FACT_VARS environment variable to "false" for the qemu-kvm integration test job in the GitHub Actions workflow	.github/workflows/qemu-kvm-integration-tests.yml
Propagate the Ansible inject-facts-as-vars setting into Terraform-based test runs.	Add SR_ANSIBLE_INJECT_FACT_VARS=false to the list of environment variables passed into the Terraform (tft) workflow job so downstream test tooling can respect the new default	.github/workflows/tft.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider using the same ANSIBLE_INJECT_FACT_VARS environment variable directly in the tft.yml workflow instead of introducing SR_ANSIBLE_INJECT_FACT_VARS unless there is a strong reason for the extra indirection, to keep configuration of this behavior consistent across workflows.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider using the same `ANSIBLE_INJECT_FACT_VARS` environment variable directly in the `tft.yml` workflow instead of introducing `SR_ANSIBLE_INJECT_FACT_VARS` unless there is a strong reason for the extra indirection, to keep configuration of this behavior consistent across workflows.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}