ci: Pass in __bootc_validation as boolean, not string

[richm]

Pass in a YAML true value as __bootc_validation: true using
the --extra-vars option to ensure that __bootc_validation is
treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Ensure __bootc_validation is passed as a boolean in CI, upgrade tox-lsr to the latest version, refine TF rerun logic to include cancelled runs, and document how to run CI tests locally with tox-lsr and QEMU

Bug Fixes:

• Pass __bootc_validation as a YAML boolean instead of a string in CI workflows

CI:

• Bump tox-lsr to version 3.11.1 across GitHub workflows
• Include cancelled conclusions alongside failures in tft_citest_bad workflow

Documentation:

• Add instructions for running CI tests locally with tox-lsr and QEMU in contributing.md

[sourcery-ai]

Reviewer's Guide

This PR updates the CI toolchain by converting __bootc_validation to a YAML boolean, upgrading the tox-lsr dependency to 3.11.1 across workflows, improving Terraform CI failure handling, and adding a comprehensive local CI testing guide.

File-Level Changes

Change	Details	Files
Bump tox-lsr dependency to 3.11.1 in CI workflows	update pip3 install command to use tox-lsr@3.11.1 across all workflows	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Treat __bootc_validation as a boolean in qemu CI	replace string extra-var syntax with YAML boolean format for __bootc_validation	.github/workflows/qemu-kvm-integration-tests.yml
Extend Terraform CI failure detection	adjust jq filter to include cancelled runs add comment explaining TF test flakiness	.github/workflows/tft_citest_bad.yml
Add local CI testing instructions	introduce 'Running CI Tests Locally' section with qemu and tox-lsr setup steps	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider extracting the tox-lsr version and installation step into a shared workflow or reusable action to reduce duplication and simplify future version bumps.
• Add a brief inline comment in tft_citest_bad.yml explaining why cancelled runs are now filtered alongside failures to give context for future maintainers.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Consider extracting the tox-lsr version and installation step into a shared workflow or reusable action to reduce duplication and simplify future version bumps.
- Add a brief inline comment in tft_citest_bad.yml explaining why cancelled runs are now filtered alongside failures to give context for future maintainers.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}