ci: use tox-lsr 3.12.0 for osbuild_config.yml feature#200
Merged
Conversation
Use tox-lsr 3.12.0 for the new osbuild_config.yml feature for bootc and users linux-system-roles/tox-lsr#211 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider centralizing the tox-lsr version in a single location or reusable workflow to avoid duplicating the bump across multiple CI files.
- Verify that the new osbuild_config.yml feature is actually exercised in your CI jobs so you catch any regressions introduced by tox-lsr 3.12.0.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing the tox-lsr version in a single location or reusable workflow to avoid duplicating the bump across multiple CI files.
- Verify that the new osbuild_config.yml feature is actually exercised in your CI jobs so you catch any regressions introduced by tox-lsr 3.12.0.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
failures will be fixed in a subsequent commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use tox-lsr 3.12.0 for the new osbuild_config.yml feature for bootc and users
linux-system-roles/tox-lsr#211
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Upgrade tox-lsr to version 3.12.0 in all GitHub Actions workflows to enable the new osbuild_config.yml feature.
CI: